Separate Wasmstore from normal db: initial #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If not found in db - returns an error instead of marking state for revertion
PlasmaPower
reviewed
May 10, 2024
arbitrum/recordingdb.go
Outdated
| } else if ok, _ := rawdb.IsActivatedModuleKey(key); ok { | ||
| // Arbitrum: the module is non-consensus (only its hash is) | ||
| return db.diskDb.Get(key) | ||
| return db.wasmDb.Get(key) |
There was a problem hiding this comment.
Will these ever be called? Shouldn't they be called on the wasm database instead?
There was a problem hiding this comment.
moved some things around and now it is indeed not needed
PlasmaPower
requested changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.