Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposes CacheConfig.triedbConfig #330

Merged
merged 4 commits into from
Jul 22, 2024
Merged

Exposes CacheConfig.triedbConfig #330

merged 4 commits into from
Jul 22, 2024

Conversation

diegoximenes
Copy link
Contributor

Exposes CacheConfig.triedbConfig to be used by Nitro when initializing arbos in database.

Addresses this PR change request: OffchainLabs/nitro#2324 (comment)

@cla-bot cla-bot bot added the s CLA signed label Jun 17, 2024
@diegoximenes diegoximenes marked this pull request as ready for review June 17, 2024 15:44
gligneul
gligneul previously approved these changes Jun 17, 2024
magicxyyz
magicxyyz previously approved these changes Jun 17, 2024
Copy link
Contributor

@magicxyyz magicxyyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tsahee
tsahee previously approved these changes Jul 18, 2024
Copy link
Contributor

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegoximenes diegoximenes dismissed stale reviews from tsahee, magicxyyz, and gligneul via dbf2a65 July 18, 2024 19:03
@diegoximenes diegoximenes requested a review from tsahee July 19, 2024 16:06
Copy link
Contributor

@magicxyyz magicxyyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 merged commit 334c337 into master Jul 22, 2024
6 checks passed
@joshuacolvin0 joshuacolvin0 deleted the expose_triedbconfig branch July 22, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants