Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for conditional OSP #175

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Add unit test for conditional OSP #175

merged 2 commits into from
Apr 26, 2024

Conversation

gvladika
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the s label Apr 25, 2024
@gvladika gvladika requested a review from gzeoneth April 25, 2024 15:42
gzeoneth
gzeoneth approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@gzeoneth gzeoneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would add an assertNe to make sure the 2 osp return different hashes, otherwise lgtm

@gvladika gvladika merged commit 6d86f7a into cond-osp Apr 26, 2024
8 of 10 checks passed
@gvladika gvladika deleted the unit-cond-osp branch April 26, 2024 08:20
@gzeoneth gzeoneth mentioned this pull request Jul 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gzeoneth gzeoneth gzeoneth approved these changes

Assignees
No one assigned
Labels
s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gvladika @gzeoneth