Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add note regarding reorg #264

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

docs: add note regarding reorg #264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/rollup/RollupCreator.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,8 @@ contract RollupCreator is Ownable {
* @dev - config.rollupOwner should have executor role on upgradeExecutor
* @dev - Bridge should have a single inbox and outbox
* @dev - Validators, batch posters and batch poster manager should be set if provided
* @dev While the rollup address is salted with deployParams and thus is safe from reorgs, other contracts such as the inbox are not.
* @dev Users should wait for finality before depositing funds to the rollup through the inbox.
* @param deployParams The parameters for the rollup deployment. It consists of:
* - config The configuration for the rollup
* - validators The list of validator addresses, not used when set to empty list
Expand Down
Loading