use create2 in BridgeCreator #265
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godzillaba
commented
Nov 18, 2024
src/rollup/BridgeCreator.sol
Outdated
| } | ||
|
|
||
| // use create2 salt to ensure deterministic addresses | ||
| bytes32 create2Salt = keccak256(abi.encode(adminProxy, rollup, nativeToken, maxTimeVariation)); |
There was a problem hiding this comment.
technically adminProxy isn't required in the salt since it's a constructor arg. can't hurt to include it though IMO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the salt includes all the
createBridgeargs in case it is called with arollupthat wasn't created byRollupCreator. If all args aren't included in this scenario, you could frontrun a bridge creation with different arguments, preventing the proper deployment through the bridge creator.