-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recreate state for RPCs #1455
Recreate state for RPCs #1455
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1455 +/- ##
==========================================
- Coverage 56.40% 49.76% -6.64%
==========================================
Files 216 259 +43
Lines 32367 31314 -1053
Branches 0 555 +555
==========================================
- Hits 18256 15584 -2672
- Misses 11936 13532 +1596
- Partials 2175 2198 +23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The nitro side LGTM but I have a comment on the geth side
LGTM but has acquired merge conflicts. After fixing those though, both this and the geth side are ready to merge :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds system tests for state recreation for RPCs and updates go-ethereum submodule.
Pulls in OffchainLabs/go-ethereum#191