Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate state for RPCs #1455

Merged
merged 30 commits into from
Aug 15, 2023
Merged

Recreate state for RPCs #1455

merged 30 commits into from
Aug 15, 2023

Conversation

magicxyyz
Copy link
Contributor

@magicxyyz magicxyyz commented Jan 24, 2023

Adds system tests for state recreation for RPCs and updates go-ethereum submodule.

Pulls in OffchainLabs/go-ethereum#191

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jan 24, 2023
@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Merging #1455 (32b73a5) into master (02529f1) will decrease coverage by 6.64%.
The diff coverage is 0.00%.

❗ Current head 32b73a5 differs from pull request most recent head 662becc. Consider uploading reports for the commit 662becc to get more accurate results

@@            Coverage Diff             @@
##           master    #1455      +/-   ##
==========================================
- Coverage   56.40%   49.76%   -6.64%     
==========================================
  Files         216      259      +43     
  Lines       32367    31314    -1053     
  Branches        0      555     +555     
==========================================
- Hits        18256    15584    -2672     
- Misses      11936    13532    +1596     
- Partials     2175     2198      +23     

Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nitro side LGTM but I have a comment on the geth side

@PlasmaPower
Copy link
Collaborator

LGTM but has acquired merge conflicts. After fixing those though, both this and the geth side are ready to merge :)

Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower merged commit 7a095d2 into master Aug 15, 2023
7 checks passed
@PlasmaPower PlasmaPower deleted the recreate-state-for-rpcs branch August 15, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants