Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prunning system test #2021

Merged
merged 16 commits into from
Dec 23, 2023
Merged

Add prunning system test #2021

merged 16 commits into from
Dec 23, 2023

Conversation

magicxyyz
Copy link
Contributor

@magicxyyz magicxyyz commented Dec 15, 2023 •
edited
Loading

This PR:

  • adds initial test for prunning.PruneChainDb
  • moves PruneChainDb to new package cmd/prunning
  • moves InitConfig to cmd/conf package
  • changes ArbDB directory name used in system tests from "arbdb" to "arbitrumdata", to match the naming used in main binary

pulls: OffchainLabs/go-ethereum#276

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Dec 15, 2023
@yucem44 yucem44 mentioned this pull request Dec 16, 2023
Closed
Tristan-Wilson
Tristan-Wilson reviewed Dec 22, 2023
View reviewed changes
cmd/prunning/prunning.go Outdated Show resolved Hide resolved
system_tests/prunning_test.go Outdated Show resolved Hide resolved
Tristan-Wilson
Tristan-Wilson requested changes Dec 22, 2023
View reviewed changes
Copy link
Member

@Tristan-Wilson Tristan-Wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting package name fix.

Tristan-Wilson
Tristan-Wilson approved these changes Dec 23, 2023
View reviewed changes
Copy link
Member

@Tristan-Wilson Tristan-Wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tristan-Wilson Tristan-Wilson merged commit 07710dc into master Dec 23, 2023
8 checks passed
@Tristan-Wilson Tristan-Wilson deleted the prunning-fix-test branch December 23, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tristan-Wilson Tristan-Wilson Tristan-Wilson approved these changes

Assignees
No one assigned
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magicxyyz @Tristan-Wilson