Refactor gotestsum "test one package at a time" procedure #2611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
diegoximenes
force-pushed
the
gotestsum_improvement
branch
6 times, most recently
from
25ddacc
to
0689ae8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2611 +/- ##
==========================================
+ Coverage 23.06% 23.41% +0.35%
==========================================
Files 260 260
Lines 37354 37482 +128
==========================================
+ Hits 8615 8778 +163
+ Misses 27290 27255 -35
Partials 1449 1449 |
tsahee
requested changes
Sep 16, 2024
.github/workflows/gotestsum.sh
Outdated
| cmd="$cmd -coverprofile=coverage.txt -covermode=atomic -coverpkg=./...,./go-ethereum/..." | ||
| fi | ||
|
|
||
| if [ "$write_full_log" == true ]; then |
There was a problem hiding this comment.
I know this matches previous behaviour, but there is no good reason to evern -not- do that. Meaning, the stdbuf trick should be set on all invocations.
Possibly, someone may want to run the script on his own computer and only in this case they won't want to use --write-full-log
There was a problem hiding this comment.
All invocations write to full.log now
diegoximenes
force-pushed
the
gotestsum_improvement
branch
from
c2f9d9f
to
73da786
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves NIT-2693
Moves gotestsum call to a bash script to avoid code duplication.