Add timeboosted information to broadcast feed #2695
Conversation
cla-bot
bot
added
the
s
ganeshvanahalli
requested review from
Tristan-Wilson,
gligneul and
amsanghi
broadcaster/message/message.go
Outdated
| maxTxCount := (len(m.Timeboosted) - 1) * 8 | ||
| if txIndex >= maxTxCount { | ||
| return false | ||
| } | ||
| return m.Timeboosted[1+(txIndex/8)]&(1<<(txIndex%8)) != 0 |
There was a problem hiding this comment.
I think it's worth making a special type for the []byte representing Timeboosted to encapsulate this functionality.
There was a problem hiding this comment.
I think the idea behind the versioning is that what we're storing in this byte buffer is supposed to be block metadata which may grow to include more things than just whether txs were timeboosted or not. See NIT-2779. So it should be called block metadata or something similar, and schema.go should change too.
There was a problem hiding this comment.
Agreed, fixed it
There was a problem hiding this comment.
What I mean is having the logic for checking if a tx is timeboosted being a function on the type you currently have called Timeboosted (which should probably also be called BlockMetadata. This goes for anywhere the is logic that cares about the bitwise representation of the block metadata.
There was a problem hiding this comment.
Ahh that makes a lot of sense, i'll rename the type and have the func defined on that
ganeshvanahalli
changed the title
This PR adds a new field
blockMetadatato theBroadcastFeedMessagestruct that represents whether a particular transaction in the block was time-boosted or not.The field
blockMetadatais an array of bytes and it starts with a 0 (version) followed by ceil(N/8) number of bytes where N is the number of txs in the block. Basicallynth bit of thekth byte of blockMetadata byte array represents the status of8*(k-1)+(n+1)th transaction, if its 1 means the tx was timeboosted else it wasn't.Example: if blockMetadata array viewed as bits is
00000000 01100101then 2nd, 3rd, 6th and 8th transactions in the block were timeboosted.Resolves NIT-2779