Fixes errcheck errors pointed by golangci-lint #2782
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
diegoximenes
changed the title
eljobe
requested changes
Nov 12, 2024
There was a problem hiding this comment.
Sorry I didn't see this before making: #2785
But, if we wanted to ignore these errors, why wouldn't we just remove this part: https://github.com/OffchainLabs/nitro/blob/master/.golangci.yml#L28-L31
I think we should either fix them with #2785 or disable them in the linter's config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
errcheck errors are being generated by golangci-lint version 1.62.0.
Those errors were not being generated by previous golangci-lint versions.
This PR solves the issue.