Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocks ReExecution should require --init.then-quit #2792

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Blocks ReExecution should require --init.then-quit #2792

merged 1 commit into from
Nov 19, 2024
+18 −21

Conversation

ganeshvanahalli
Copy link
Contributor

This PR makes enforces that blocks re-execution can only be carried out when --init.then-quit is set too.

Resolves NIT-2948

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Nov 18, 2024
eljobe
eljobe approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@eljobe eljobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ganeshvanahalli ganeshvanahalli merged commit 0b60721 into master Nov 19, 2024
17 checks passed
@ganeshvanahalli ganeshvanahalli deleted the blocksreexecutor-require-initthenquit branch November 19, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eljobe eljobe eljobe approved these changes

@joshuacolvin0 joshuacolvin0 Awaiting requested review from joshuacolvin0

@Tristan-Wilson Tristan-Wilson Awaiting requested review from Tristan-Wilson

Assignees
No one assigned
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ganeshvanahalli @eljobe @joshuacolvin0