Alloy 0.8.3 #163
Closed
Alloy 0.8.3 #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests are important before upgrading alloy to avoid misuing their API and causing errors.
This alloy version includes generic integer types, so instead of implementing those on our end, we special case the built-in integer sizes so they work with both primitive ints and alloy generics.
chrisco512
previously approved these changes
Oct 9, 2024
rory-ocl
dismissed
chrisco512’s stale review
The merge-base changed after approval.
|
already merged in other PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This upgrades the alloy version to 0.8.3.
This alloy version includes generic integer types, so instead of implementing those on our end, we special case the built-in integer sizes so they work with both primitive ints and alloy generics.
This PR also includes some unit tests for encoding and decoding to ensure that the alloy upgrade does not break this functionality.
Checklist