Update creation code generation #58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6389b4a.
…ne compiler would generate This will enable source code verification of the deployed token bridge contracts on the child chain
gzeoneth
requested changes
Nov 23, 2023
| * - 61xxxx - push 2 bytes of `code` length | ||
| * - 806100206000396000f3fe - copy deployed code to memory and return the location of it | ||
| * @param code Deployed bytecode to which constructor bytecode will be prepended | ||
| * @return Creation code of a new contract | ||
| */ | ||
| function _creationCodeFor(bytes memory code) internal pure returns (bytes memory) { |
There was a problem hiding this comment.
can we have this function as a lib function shared by both contracts?
| * - 61xxxx - push 2 bytes of `code` length | ||
| * - 806100206000396000f3fe - copy deployed code to memory and return the location of it | ||
| * @param code Deployed bytecode to which constructor bytecode will be prepended | ||
| * @return Creation code of a new contract | ||
| */ | ||
| function _creationCodeFor(bytes memory code) internal pure returns (bytes memory) { |
There was a problem hiding this comment.
This changes the returned address of
we might want to have a way to redeploy the multicall contract even if the rest of the token bridge is already deployed using the old way
|
out of date |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.