[Release] - Hide Clearinghouse V1 + BLV for users w/o positions. Cooler Extend Loan Approval Fix #3021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
brightiron
commented
Nov 7, 2023
brightiron
commented
- Hide Clearinghouse V1 for users w/o positions
- Hide BLV For Users w/o active positions
- Fix issue w/ Cooler Extend Loan Spend Approvals. In some cases a user would not be prompted for an approval if they have an existing spend approval, but it was below the limit required to roll the loan
* hide BLV for users that dont have positions. remove vaults list * revert * remove console logs
unbanksy
approved these changes
Nov 13, 2023
| @@ -86,6 +86,9 @@ export const Vault = () => { | |||
| const isWithdrawal = searchParams.get("withdraw") ? true : false; | |||
| const theme = useTheme(); | |||
| const mobile = useMediaQuery(theme.breakpoints.down("sm")); | |||
|
|
|||
| const { data: vaults, isLoading: vaultsLoading } = useGetSingleSidedLiquidityVaults(); | |||
| const vaultsWithDeposits = vaults && vaults.filter(vault => vault.lpTokenBalance !== "0"); | |||
There was a problem hiding this comment.
Saw you convert to Number in other places. Might be good to do it here, as well. In general, wonder if it's worth pulling vaultsWithDeposits out into a common helper file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.