Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ProcessScheduler memleak #1053

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

antpensi
Copy link

@antpensi antpensi commented Oct 4, 2023

Reducing the int.MaxValue here to an arbitrary low int value seems to alleviate the suspected memory leak described in #1037

Hoping this PR can serve as the start of a conversation about what might be a more proper solution.

@github-actions github-actions bot added this to the v0.19.10 milestone Oct 4, 2023
@antpensi
Copy link
Author

antpensi commented Oct 5, 2023

@microsoft-github-policy-service agree company="VMware"

@antpensi antpensi marked this pull request as ready for review October 31, 2023 18:40
@antpensi
Copy link
Author

Hi @JoeRobich - please excuse the direct ping. Do you happen to know the right person to get eyes on this issue? I do not necessarily think the changes in this PR are the correct solution, but it does seem to alleviate the memory leak described in #1037. Hope to use this as a conversation point.

Thank you

@JoeRobich
Copy link
Member

Hi @antpensi - I am likely the right person, thanks for the ping.

I saw this come up earlier and still need to investigate how the ReplaySubject is being used. Am I right that it captures requests while a serial request is being processed, so that they can be replayed when the blocking request is complete? Why is 6 seconds long enough? Does a replay subject make the most sense here or would a queue work just as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants