Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle task cancelation in ResponseRouter #1190

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ycholette
Copy link
Contributor

We stumble into a case where we wanted to add timeout to Initialize() and Shutdown() because those two methods can potentially never return. In the case of Shutdow(), it seems to be happening in RequestShutdown() when the client's process has already exited. This allow for the rest of the method to be executed when the timeout is reached (important if you want to reconnect again). For the case if Initialize(), the reason is not clear, but it seems to happen in SendRequest(ClientSettings, token). It's possible that the client's process is not totally ready to accept connection. In any cases, a timeout really help in those cases.

@github-actions github-actions bot added this to the v0.19.10 milestone Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants