forked from run-llama/llama_index
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/code parser #11
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sive_scopes"] and add the current scope to the list. # Aider chat conversation: USER: Convert all instances of metadata["scopes"] to metadata["inclusive_scopes"] and add the current scope to the list. For example, if the block starts with "class Foo:" add {"name": "Foo", "type": "class"} to the list, even though it's not yet in scope, because it is defined at the start of the chunk. ASSISTANT: To implement this change, we need to modify the file `tests/node_parser/test_code_parser.py`. We will replace all instances of `metadata["scopes"]` with `metadata["inclusive_scopes"]` and add the current scope to the list. Here are the changes: ```python tests/node_parser/test_code_parser.py <<<<<<< HEAD assert chunks[0].metadata["scopes"] == [] assert chunks[1].metadata["scopes"] == [{'name': "Foo", 'type': "class"}] assert chunks[2].metadata["scopes"] == [{'name': "Foo", 'type': "class"}] assert chunks[0].metadata["scopes"] == [] assert chunks[1].metadata["scopes"] == [] assert chunks[0].metadata["scopes"] == [] assert chunks[1].metadata["scopes"] == [] assert chunks[0].metadata["scopes"] == [] assert chunks[1].metadata["scopes"] == [] assert chunks[2].metadata["scopes"] == [{'name': "Example", 'type': "class"}] assert chunks[3].metadata["scopes"] == [] assert chunks[0].metadata["scopes"] == [] assert chunks[1].metadata["scopes"] == [] assert chunks[2].metadata["scopes"] == [] assert chunks[3].metadata["scopes"] == [{'name': "ExampleComponent", 'type': "function"}] assert chunks[0].metadata["scopes"] == [] assert chunks[1].metadata["scopes"] == [{'name': "main", 'type': "function"}] ======= assert chunks[0].metadata["inclusive_scopes"] == [{'name': "Foo", 'type': "class"}] assert chunks[1].metadata["inclusive_scopes"] == [{'name': "Foo", 'type': "class"}, {'name': "foo", 'type': "function"}] assert chunks[2].metadata["inclusive_scopes"] == [{'name': "Foo", 'type': "class"}, {'name': "baz", 'type': "function"}] assert chunks[0].metadata["inclusive_scopes"] == [] assert chunks[1].metadata["inclusive_scopes"] == [] assert chunks[0].metadata["inclusive_scopes"] == [{'name': "foo", 'type': "function"}] assert chunks[1].metadata["inclusive_scopes"] == [{'name': "baz", 'type': "function"}] assert chunks[0].metadata["inclusive_scopes"] == [{'name': "foo", 'type': "function"}] assert chunks[1].metadata["inclusive_scopes"] == [{'name': "Example", 'type': "class"}] assert chunks[2].metadata["inclusive_scopes"] == [{'name': "Example", 'type': "class"}, {'name': "exampleMethod", 'type': "function"}] assert chunks[3].metadata["inclusive_scopes"] == [{'name': "baz", 'type': "function"}] assert chunks[0].metadata["inclusive_scopes"] == [] assert chunks[1].metadata["inclusive_scopes"] == [{'name': "Person", 'type': "interface"}] assert chunks[2].metadata["inclusive_scopes"] == [{'name': "ExampleComponent", 'type': "function"}] assert chunks[3].metadata["inclusive_scopes"] == [{'name': "ExampleComponent", 'type': "function"}, {'name': "div", 'type': "tag"}] assert chunks[0].metadata["inclusive_scopes"] == [] assert chunks[1].metadata["inclusive_scopes"] == [{'name': "main", 'type': "function"}] >>>>>>> updated ``` Please note that the type of the scope (class, function, interface, tag) is assumed based on the context of the code. If the type is different, please provide the correct type. USER: InvalidEditBlock: edit failed! tests/node_parser/test_code_parser.py does not contain the *exact sequence* of HEAD lines you specified. Try again. DO NOT skip blank lines, comments, docstrings, etc! The HEAD block needs to be EXACTLY the same as the lines in tests/node_parser/test_code_parser.py with nothing missing! tests/node_parser/test_code_parser.py does not contain these 17 exact lines in a row: ``` assert chunks[0].metadata["scopes"] == [] assert chunks[1].metadata["scopes"] == [{'name': "Foo", 'type': "class"}] assert chunks[2].metadata["scopes"] == [{'name': "Foo", 'type': "class"}] assert chunks[0].metadata["scopes"] == [] assert chunks[1].metadata["scopes"] == [] assert chunks[0].metadata["scopes"] == [] assert chunks[1].metadata["scopes"] == [] assert chunks[0].metadata["scopes"] == [] assert chunks[1].metadata["scopes"] == [] assert chunks[2].metadata["scopes"] == [{'name': "Example", 'type': "class"}] assert chunks[3].metadata["scopes"] == [] assert chunks[0].metadata["scopes"] == [] assert chunks[1].metadata["scopes"] == [] assert chunks[2].metadata["scopes"] == [] assert chunks[3].metadata["scopes"] == [{'name': "ExampleComponent", 'type': "function"}] assert chunks[0].metadata["scopes"] == [] assert chunks[1].metadata["scopes"] == [{'name': "main", 'type': "function"}] ``` ASSISTANT: I apologize for the confusion. I misunderstood the requirement. I will now provide the changes in smaller chunks to ensure accuracy. Here are the changes: ```python tests/node_parser/test_code_parser.py <<<<<<< HEAD assert chunks[0].metadata["scopes"] == [] ======= assert chunks[0].metadata["inclusive_scopes"] == [{'name': "Foo", 'type': "class"}] >>>>>>> updated ``` ```python tests/node_parser/test_code_parser.py <<<<<<< HEAD assert chunks[1].metadata["scopes"] == [{'name': "Foo", 'type': "class"}] ======= assert chunks[1].metadata["inclusive_scopes"] == [{'name': "Foo", 'type': "class"}, {'name': "foo", 'type': "function"}] >>>>>>> updated ``` ```python tests/node_parser/test_code_parser.py <<<<<<< HEAD assert chunks[2].metadata["scopes"] == [{'name': "Foo", 'type': "class"}] ======= assert chunks[2].metadata["inclusive_scopes"] == [{'name': "Foo", 'type': "class"}, {'name': "baz", 'type': "function"}] >>>>>>> updated ``` Please apply these changes and let me know if there are any issues. I will continue to provide the remaining changes in the same manner.
…inclusive_scopes"]` in `tests/node_parser/test_code_parser.py`. # Aider chat conversation: USER: Continue with other scopes fields ASSISTANT: To replace all instances of `metadata["scopes"]` with `metadata["inclusive_scopes"]` in the file `tests/node_parser/test_code_parser.py`, we need to make changes in multiple places. Here are the changes: ```python tests/node_parser/test_code_parser.py <<<<<<< HEAD assert "scopes" in chunks[0].metadata ======= assert "inclusive_scopes" in chunks[0].metadata >>>>>>> updated ``` ```python tests/node_parser/test_code_parser.py <<<<<<< HEAD assert "scopes" in chunks[1].metadata ======= assert "inclusive_scopes" in chunks[1].metadata >>>>>>> updated ``` ```python tests/node_parser/test_code_parser.py <<<<<<< HEAD assert "scopes" in chunks[2].metadata ======= assert "inclusive_scopes" in chunks[2].metadata >>>>>>> updated ``` ```python tests/node_parser/test_code_parser.py <<<<<<< HEAD assert "scopes" in chunks[0].metadata ======= assert "inclusive_scopes" in chunks[0].metadata >>>>>>> updated ``` ```python tests/node_parser/test_code_parser.py <<<<<<< HEAD assert chunks[1].metadata["scopes"] == [] ======= assert chunks[1].metadata["inclusive_scopes"] == [] >>>>>>> updated ``` ```python tests/node_parser/test_code_parser.py <<<<<<< HEAD assert chunks[2].metadata["scopes"] == ["html"] ======= assert chunks[2].metadata["inclusive_scopes"] == ["html"] >>>>>>> updated ``` ```python tests/node_parser/test_code_parser.py <<<<<<< HEAD assert chunks[3].metadata["scopes"] == ["html"] ======= assert chunks[3].metadata["inclusive_scopes"] == ["html"] >>>>>>> updated ``` ```python tests/node_parser/test_code_parser.py <<<<<<< HEAD assert chunks[4].metadata["scopes"] == ["html", "body"] ======= assert chunks[4].metadata["inclusive_scopes"] == ["html", "body"] >>>>>>> updated ``` ```python tests/node_parser/test_code_parser.py <<<<<<< HEAD assert "scopes" in chunks[0].metadata ======= assert "inclusive_scopes" in chunks[0].metadata >>>>>>> updated ``` ```python tests/node_parser/test_code_parser.py <<<<<<< HEAD assert chunks[1].metadata["scopes"] == [] ======= assert chunks[1].metadata["inclusive_scopes"] == [] >>>>>>> updated ``` ```python tests/node_parser/test_code_parser.py <<<<<<< HEAD assert "scopes" in chunks[0].metadata ======= assert "inclusive_scopes" in chunks[0].metadata >>>>>>> updated ``` ```python tests/node_parser/test_code_parser.py <<<<<<< HEAD assert chunks[1].metadata["scopes"] == [] ======= assert chunks[1].metadata["inclusive_scopes"] == [] >>>>>>> updated ``` ```python tests/node_parser/test_code_parser.py <<<<<<< HEAD assert chunks[2].metadata["scopes"] == [{'name': "Example", 'type': "class"}] ======= assert chunks[2].metadata["inclusive_scopes"] == [{'name': "Example", 'type': "class"}] >>>>>>> updated ``` ```python tests/node_parser/test_code_parser.py <<<<<<< HEAD assert chunks[3].metadata["scopes"] == [] ======= assert chunks[3].metadata["inclusive_scopes"] == [] >>>>>>> updated ``` ```python tests/node_parser/test_code_parser.py <<<<<<< HEAD assert "scopes" in chunks[0].metadata ======= assert "inclusive_scopes" in chunks[0].metadata >>>>>>> updated ``` ```python tests/node_parser/test_code_parser.py <<<<<<< HEAD assert chunks[1].metadata["scopes"] == [] ======= assert chunks[1].metadata["inclusive_scopes"] == [] >>>>>>> updated ``` ```python tests/node_parser/test_code_parser.py <<<<<<< HEAD assert chunks[2].metadata["scopes"] == [] ======= assert chunks[2].metadata["inclusive_scopes"] == [] >>>>>>> updated ``` ```python tests/node_parser/test_code_parser.py <<<<<<< HEAD assert chunks[3].metadata["scopes"] == [{'name': "ExampleComponent", 'type': "function"}] ======= assert chunks[3].metadata["inclusive_scopes"] == [{'name': "ExampleComponent", 'type': "function"}] >>>>>>> updated ``` ```python tests/node_parser/test_code_parser.py <<<<<<< HEAD assert "scopes" in chunks[0].metadata ======= assert "inclusive_scopes" in chunks[0].metadata >>>>>>> updated ``` ```python tests/node_parser/test_code_parser.py <<<<<<< HEAD assert chunks[1].metadata["scopes"] == [{'name': "main", 'type': "function"}] ======= assert chunks[1].metadata["inclusive_scopes"] == [{'name': "main", 'type': "function"}] >>>>>>> updated ``` Please let me know if you need further assistance.
… scope. This will be better for CodeSplitter
…tructure and checks in `test_python_code_splitter`. # Aider chat conversation: USER: I changed around test_python_code_splitter a lot to make its tests pass. Can you examine its assertions and make the other tests have similar assertions? ASSISTANT: Sure, I can help with that. To make the other tests have similar assertions to `test_python_code_splitter`, we need to modify the following files: 1. `tests/node_parser/test_code_parser.py` Let's start with the `test_html_code_splitter` function. We need to update the assertions to match the structure and checks in `test_python_code_splitter`. The changes will include updating the `assert` statements to check for the correct `metadata` and `relationships` in each chunk. Here's the first *edit block* for `test_html_code_splitter`: ```python tests/node_parser/test_code_parser.py <<<<<<< HEAD # Test the first chunk (DOCTYPE) assert chunks[0].text.startswith("<!DOCTYPE html>") assert chunks[0].metadata["inclusive_scopes"] == [] assert chunks[0].relationships[NodeRelationship.PARENT] is None assert chunks[0].relationships[NodeRelationship.PREVIOUS] is None assert chunks[0].relationships[NodeRelationship.NEXT] == chunks[1].id_ assert chunks[0].relationships[NodeRelationship.CHILD] == [] ======= # This is the DOCTYPE scope assert chunks[0].text.startswith("<!DOCTYPE html>") assert chunks[0].metadata["module"] == "example.html" assert chunks[0].metadata["inclusive_scopes"] == [] assert NodeRelationship.PARENT not in chunks[0].relationships assert [c.node_id for c in chunks[0].relationships[NodeRelationship.CHILD]] == [chunks[1].id_] assert isinstance(chunks[0].relationships[NodeRelationship.SOURCE], RelatedNodeInfo) assert chunks[0].relationships[NodeRelationship.SOURCE].node_id == text_node.id_ assert NodeRelationship.PREVIOUS not in chunks[0].relationships assert NodeRelationship.NEXT not in chunks[0].relationships >>>>>>> updated ``` I'll continue with the rest of the functions in the next messages.
… the structure and checks in `test_python_code_splitter`. # Aider chat conversation: USER: continue ASSISTANT: Next, let's update the assertions in the `test_typescript_code_splitter` function to match the structure and checks in `test_python_code_splitter`. The changes will include updating the `assert` statements to check for the correct `metadata` and `relationships` in each chunk. Here's the *edit block* for `test_typescript_code_splitter`: ```python tests/node_parser/test_code_parser.py <<<<<<< HEAD # Test the first chunk (function foo) assert chunks[0].text.startswith("function foo()") assert chunks[0].metadata["inclusive_scopes"] == [{'name': "foo", 'type': "function"}] assert chunks[0].relationships[NodeRelationship.PARENT] is None assert chunks[0].relationships[NodeRelationship.PREVIOUS] is None assert chunks[0].relationships[NodeRelationship.NEXT] == chunks[1].id_ assert chunks[0].relationships[NodeRelationship.CHILD] == [] # Test the second chunk (function baz) assert chunks[1].text.startswith("function baz()") assert chunks[1].metadata["inclusive_scopes"] == [{'name': "baz", 'type': "function"}] assert chunks[1].relationships[NodeRelationship.PARENT] is None assert chunks[1].relationships[NodeRelationship.PREVIOUS] == chunks[0].id_ assert chunks[1].relationships[NodeRelationship.NEXT] == None assert chunks[1].relationships[NodeRelationship.CHILD] == [] ======= # This is the first function scope assert chunks[0].text.startswith("function foo()") assert chunks[0].metadata["module"] == "example.ts" assert chunks[0].metadata["inclusive_scopes"] == [{'name': "foo", 'type': "function_definition"}] assert NodeRelationship.PARENT not in chunks[0].relationships assert chunks[0].relationships[NodeRelationship.CHILD] == [] assert isinstance(chunks[0].relationships[NodeRelationship.SOURCE], RelatedNodeInfo) assert chunks[0].relationships[NodeRelationship.SOURCE].node_id == text_node.id_ assert NodeRelationship.PREVIOUS not in chunks[0].relationships assert NodeRelationship.NEXT not in chunks[0].relationships # This is the second function scope assert chunks[1].text.startswith("function baz()") assert chunks[1].metadata["module"] == "example.ts" assert chunks[1].metadata["inclusive_scopes"] == [{'name': "baz", 'type': "function_definition"}] assert NodeRelationship.PARENT not in chunks[1].relationships assert chunks[1].relationships[NodeRelationship.CHILD] == [] assert isinstance(chunks[1].relationships[NodeRelationship.SOURCE], RelatedNodeInfo) assert chunks[1].relationships[NodeRelationship.SOURCE].node_id == text_node.id_ assert NodeRelationship.PREVIOUS not in chunks[1].relationships assert NodeRelationship.NEXT not in chunks[1].relationships >>>>>>> updated ``` I'll continue with the rest of the functions in the next messages.
… like decorators while maintaining context, saving work.
…one place for all this code cluttering the repo
ryanpeach
pushed a commit
that referenced
this pull request
Feb 7, 2024
* Grammatical_error in docs/api_reference/query.rst * Grammatical error in docs/end_to_end_tutorials/dev_practices/e2e_evaluation.md * Changed word from unstructed to unstructured * Corrected the spelling of performing * Update evaluating.md Corrected the spelling of "guidelines" * Update evaluation.md Changed " things are working will together" to " things are working well together" * Update usage_pattern.md (#2) * Update usage_pattern.md Corrected the spellings of measure. * Update basic_strategies.md * Update (#8) * Introduce Google Generative Language Semantic Retriever (run-llama#9440) * Add a Gemini models for text and multi-modal. (run-llama#9452) * Add a Gemini models for text and multi-modal. Includes each of {text, mm} x {completion, chat} x {stream, one-shot} x {sync, async} for Gemini's Developer API. And two notebooks - regular text & multi-modal. * add gemini into doc and rename MM example file * Add version constraints to pip install And remove noisy output. * Enrich Gemini Example * cr * Use gemini-pro instead of ultra * cr * cr * cr --------- Co-authored-by: Haotian Zhang <[email protected]> * [version] bump to v0.9.15 (run-llama#9485) * use persist dir in faiss (run-llama#9486) * Gemini Embedding (run-llama#9476) * Gemini Embedding * cr * Merge Gemini Same Role Chat Message (run-llama#9498) * Fix Gemini Same Role Chat Msg * cr * cr * cr * cr * Teeny stray link causing weirdness (run-llama#9501) * Fixing CHANGELOG for wrong PR ID (run-llama#9505) * Overhauling indexing to emphasize VectorStoreIndex and SEO * Expanding use-cases docs: Q&A and chatbots * Fix small bug in string method of NodeWithScore (run-llama#9494) Update schema.py Avoid exception in __str__ method of NodeWithScore when the optional member variable self.score is None. * Added missing `default=None` to `LLM.system_prompt` (run-llama#9504) * Adding default=None to system_prompt to fix type errors * Added CHANGELOG entry * Update PDFReader (run-llama#9508) Add to PDFReader so that a user can specify if they want the PDF read in as one whole Document, or each page as a Document. * Updating Spelling Mistakes (run-llama#9513) * Grammatical_error in docs/api_reference/query.rst * Grammatical error in docs/end_to_end_tutorials/dev_practices/e2e_evaluation.md * Changed word from unstructed to unstructured * Corrected the spelling of performing --------- Co-authored-by: KamalSharmaShorthillsAI <[email protected]> Co-authored-by: Haotian Zhang <[email protected]> Co-authored-by: UpneetShorthillsAI <[email protected]> * FIxing Grammatical issues in docs (run-llama#9514) * Fixing Docs (run-llama#9515) * Allowing `LOCALAI_DEFAULTS` to work with `__ror__` (run-llama#9502) --------- Co-authored-by: Lawrence Tsang <[email protected]> Co-authored-by: Mark McDonald <[email protected]> Co-authored-by: Haotian Zhang <[email protected]> Co-authored-by: Logan <[email protected]> Co-authored-by: Laurie Voss <[email protected]> Co-authored-by: James Braza <[email protected]> Co-authored-by: Max <[email protected]> Co-authored-by: Alex McGraw <[email protected]> Co-authored-by: KamalSharmaShorthillsAI <[email protected]> Co-authored-by: UpneetShorthillsAI <[email protected]> * Update train_questions.txt (#5) removed a from a developing * updated basic_strategies.md and building_rag_from_scratch.md files (#6) * Update basic_strategies.md * Update building_rag_from_scratch.md * Update deprecated_terms.md , changed "THe" to "The" * Update graph_stores.md * Update guidance.md * Update vector_stores.md * This PR addresses grammatical and clarity enhancements. (#7) * Update structured_outputs.md Grammatical Improvements * Update query_transformations.md Changed followup to follow-up. * Update structured_outputs.md --------- Co-authored-by: Shorthills AI <[email protected]> * made a grammatical correction (#10) * Update train_questions.txt removed a from a developing * Update agents.md removed a from a more information * Update gatsby_license.txt (#11) * Update gatsby_license.txt grammar and tense correction: "read, understand, agree to and accept all the terms" to "read, understood, and agreed to accept all the terms", "do not agree" to "disagree", "agreement for keeping" to "agreement to keep", "unlink or detach or remove" to "unlink, detach or remove", "statements concerning tax" to "statements concerning the tax" * Update concepts.md grammar and tense correction: "or retrieved data" to "or retrieve data", "data which is" to "data that is", "class, are responsible" to "class, is responsible"," that allow you to ask question" to "that allows you to ask questions". * Update discover_llamaindex.md (run-llama#15) * Update llms.md (#9) Corrected spellings of 'results'. * Update llms.md (#13) Corrected spelling of results. * Update CHANGELOG.md (run-llama#14) fixed the spelling mistake of the evaluation * Update deprecated_terms.md Links Urls in Deprecated_terms is not working. 1. Configuring settings in the Service Context Link updated. 2. Parsing Documents into Nodes Link updated. 3. LLMs in LlamaIndex Link updated. 4. Setting LLMs in the ServiceContext updated * Update deprecated_terms.md Links Updated in Deprecated_terms mentioned below: 1. Index Usage Pattern link updated. 2. Vector Store Guide link updated 3. Vector Store Integrations link updated. 4. Index Usage Pattern link updated. 5. Vector Store Guide link updated. 6. Vector Store Integrations link updated. * Update deprecated_terms.md GPTVectorStoreIndex "Index Usage Pattern" Link updated. --------- Co-authored-by: KamalSharmaShorthillsAI <[email protected]> Co-authored-by: Haotian Zhang <[email protected]> Co-authored-by: UpneetShorthillsAI <[email protected]> Co-authored-by: ManpreetShorthillsAI <[email protected]> Co-authored-by: SakshiShorthillsAI <[email protected]> Co-authored-by: Lawrence Tsang <[email protected]> Co-authored-by: Mark McDonald <[email protected]> Co-authored-by: Logan <[email protected]> Co-authored-by: Laurie Voss <[email protected]> Co-authored-by: James Braza <[email protected]> Co-authored-by: Max <[email protected]> Co-authored-by: Alex McGraw <[email protected]> Co-authored-by: Aayush <[email protected]> Co-authored-by: Saransh Sharma <[email protected]> Co-authored-by: AbhishekYadavShorthillsAI <[email protected]> Co-authored-by: AryamanJaiswalShorthillsAI <[email protected]> Co-authored-by: Sanskar Tanwar <[email protected]> Co-authored-by: ShreeramKumawatShorthillsAI <[email protected]> Co-authored-by: Vishal <[email protected]> Co-authored-by: AashutoshPathakShorthillsAI <[email protected]> Co-authored-by: Rajneesh Singh <[email protected]>
ryanpeach
pushed a commit
that referenced
this pull request
Feb 7, 2024
* Update CHANGELOG.md * Update agents.md * Updated understanding.md (run-llama#51) * Grammatical_error in docs/api_reference/query.rst * Grammatical error in docs/end_to_end_tutorials/dev_practices/e2e_evaluation.md * Changed word from unstructed to unstructured * Corrected the spelling of performing * Update evaluating.md Corrected the spelling of "guidelines" * Update evaluation.md Changed " things are working will together" to " things are working well together" * Update usage_pattern.md (#2) * Update usage_pattern.md Corrected the spellings of measure. * Update basic_strategies.md * Update (#8) * Introduce Google Generative Language Semantic Retriever (run-llama#9440) * Add a Gemini models for text and multi-modal. (run-llama#9452) * Add a Gemini models for text and multi-modal. Includes each of {text, mm} x {completion, chat} x {stream, one-shot} x {sync, async} for Gemini's Developer API. And two notebooks - regular text & multi-modal. * add gemini into doc and rename MM example file * Add version constraints to pip install And remove noisy output. * Enrich Gemini Example * cr * Use gemini-pro instead of ultra * cr * cr * cr --------- Co-authored-by: Haotian Zhang <[email protected]> * [version] bump to v0.9.15 (run-llama#9485) * use persist dir in faiss (run-llama#9486) * Gemini Embedding (run-llama#9476) * Gemini Embedding * cr * Merge Gemini Same Role Chat Message (run-llama#9498) * Fix Gemini Same Role Chat Msg * cr * cr * cr * cr * Teeny stray link causing weirdness (run-llama#9501) * Fixing CHANGELOG for wrong PR ID (run-llama#9505) * Overhauling indexing to emphasize VectorStoreIndex and SEO * Expanding use-cases docs: Q&A and chatbots * Fix small bug in string method of NodeWithScore (run-llama#9494) Update schema.py Avoid exception in __str__ method of NodeWithScore when the optional member variable self.score is None. * Added missing `default=None` to `LLM.system_prompt` (run-llama#9504) * Adding default=None to system_prompt to fix type errors * Added CHANGELOG entry * Update PDFReader (run-llama#9508) Add to PDFReader so that a user can specify if they want the PDF read in as one whole Document, or each page as a Document. * Updating Spelling Mistakes (run-llama#9513) * Grammatical_error in docs/api_reference/query.rst * Grammatical error in docs/end_to_end_tutorials/dev_practices/e2e_evaluation.md * Changed word from unstructed to unstructured * Corrected the spelling of performing --------- Co-authored-by: KamalSharmaShorthillsAI <[email protected]> Co-authored-by: Haotian Zhang <[email protected]> Co-authored-by: UpneetShorthillsAI <[email protected]> * FIxing Grammatical issues in docs (run-llama#9514) * Fixing Docs (run-llama#9515) * Allowing `LOCALAI_DEFAULTS` to work with `__ror__` (run-llama#9502) --------- Co-authored-by: Lawrence Tsang <[email protected]> Co-authored-by: Mark McDonald <[email protected]> Co-authored-by: Haotian Zhang <[email protected]> Co-authored-by: Logan <[email protected]> Co-authored-by: Laurie Voss <[email protected]> Co-authored-by: James Braza <[email protected]> Co-authored-by: Max <[email protected]> Co-authored-by: Alex McGraw <[email protected]> Co-authored-by: KamalSharmaShorthillsAI <[email protected]> Co-authored-by: UpneetShorthillsAI <[email protected]> * Update train_questions.txt (#5) removed a from a developing * updated basic_strategies.md and building_rag_from_scratch.md files (#6) * Update basic_strategies.md * Update building_rag_from_scratch.md * Update deprecated_terms.md , changed "THe" to "The" * Update graph_stores.md * Update guidance.md * Update vector_stores.md * This PR addresses grammatical and clarity enhancements. (#7) * Update structured_outputs.md Grammatical Improvements * Update query_transformations.md Changed followup to follow-up. * Update structured_outputs.md --------- Co-authored-by: Shorthills AI <[email protected]> * made a grammatical correction (#10) * Update train_questions.txt removed a from a developing * Update agents.md removed a from a more information * Update gatsby_license.txt (#11) * Update gatsby_license.txt grammar and tense correction: "read, understand, agree to and accept all the terms" to "read, understood, and agreed to accept all the terms", "do not agree" to "disagree", "agreement for keeping" to "agreement to keep", "unlink or detach or remove" to "unlink, detach or remove", "statements concerning tax" to "statements concerning the tax" * Update concepts.md grammar and tense correction: "or retrieved data" to "or retrieve data", "data which is" to "data that is", "class, are responsible" to "class, is responsible"," that allow you to ask question" to "that allows you to ask questions". * Update discover_llamaindex.md (run-llama#15) * Update llms.md (#9) Corrected spellings of 'results'. * Update llms.md (#13) Corrected spelling of results. * Update CHANGELOG.md (run-llama#14) fixed the spelling mistake of the evaluation * Update deprecated_terms.md Links Urls in Deprecated_terms is not working. 1. Configuring settings in the Service Context Link updated. 2. Parsing Documents into Nodes Link updated. 3. LLMs in LlamaIndex Link updated. 4. Setting LLMs in the ServiceContext updated * Update deprecated_terms.md Links Updated in Deprecated_terms mentioned below: 1. Index Usage Pattern link updated. 2. Vector Store Guide link updated 3. Vector Store Integrations link updated. 4. Index Usage Pattern link updated. 5. Vector Store Guide link updated. 6. Vector Store Integrations link updated. * Update deprecated_terms.md GPTVectorStoreIndex "Index Usage Pattern" Link updated. * Update chatbots.md Improve clarity and consistency in the Chatbots section of the documentation: 1. Corrected the term 'LLM's' to 'LLMs' for consistency. 2. Modified 'Here's some relevant resources' to 'Here are some relevant resources' for grammatical correctness. * Update chatbots.md with spelling : chatbots Previous : chat bots Corrected : chatbots * Update multimodal.md removed an extra word : "out" for consistency and clarity * Update chatbots.md * Update agents.md * Update embeddings.md * Update understanding.md * Update extraction.md --------- Co-authored-by: KamalSharmaShorthillsAI <[email protected]> Co-authored-by: Shorthills AI <[email protected]> Co-authored-by: Haotian Zhang <[email protected]> Co-authored-by: UpneetShorthillsAI <[email protected]> Co-authored-by: ManpreetShorthillsAI <[email protected]> Co-authored-by: SakshiShorthillsAI <[email protected]> Co-authored-by: Lawrence Tsang <[email protected]> Co-authored-by: Mark McDonald <[email protected]> Co-authored-by: Logan <[email protected]> Co-authored-by: Laurie Voss <[email protected]> Co-authored-by: James Braza <[email protected]> Co-authored-by: Max <[email protected]> Co-authored-by: Alex McGraw <[email protected]> Co-authored-by: Aayush <[email protected]> Co-authored-by: Saransh Sharma <[email protected]> Co-authored-by: AbhishekYadavShorthillsAI <[email protected]> Co-authored-by: AryamanJaiswalShorthillsAI <[email protected]> Co-authored-by: Sanskar Tanwar <[email protected]> Co-authored-by: ShreeramKumawatShorthillsAI <[email protected]> Co-authored-by: Vishal <[email protected]> Co-authored-by: AashutoshPathakShorthillsAI <[email protected]> Co-authored-by: Rajneesh Singh <[email protected]> Co-authored-by: VagishaMisraShorthillsAI <[email protected]> Co-authored-by: PankajKumarShorthillsAI <[email protected]> Co-authored-by: Adarsh Shrivastav <[email protected]> Co-authored-by: Puneet Dhiman <[email protected]> Co-authored-by: AmitSinghShorthillsAI <[email protected]> * Update embeddings.md * Update embeddings.md * Update embeddings.md * Update embeddings.md --------- Co-authored-by: ChetnaGuptaShorthillsAI <[email protected]> Co-authored-by: Puneet Dhiman <[email protected]> Co-authored-by: AdityaKalraShorthillsAI <[email protected]> Co-authored-by: KamalSharmaShorthillsAI <[email protected]> Co-authored-by: Haotian Zhang <[email protected]> Co-authored-by: UpneetShorthillsAI <[email protected]> Co-authored-by: ManpreetShorthillsAI <[email protected]> Co-authored-by: SakshiShorthillsAI <[email protected]> Co-authored-by: Lawrence Tsang <[email protected]> Co-authored-by: Mark McDonald <[email protected]> Co-authored-by: Logan <[email protected]> Co-authored-by: Laurie Voss <[email protected]> Co-authored-by: James Braza <[email protected]> Co-authored-by: Max <[email protected]> Co-authored-by: Alex McGraw <[email protected]> Co-authored-by: Aayush <[email protected]> Co-authored-by: Saransh Sharma <[email protected]> Co-authored-by: AbhishekYadavShorthillsAI <[email protected]> Co-authored-by: AryamanJaiswalShorthillsAI <[email protected]> Co-authored-by: Sanskar Tanwar <[email protected]> Co-authored-by: ShreeramKumawatShorthillsAI <[email protected]> Co-authored-by: Vishal <[email protected]> Co-authored-by: AashutoshPathakShorthillsAI <[email protected]> Co-authored-by: Rajneesh Singh <[email protected]> Co-authored-by: VagishaMisraShorthillsAI <[email protected]> Co-authored-by: PankajKumarShorthillsAI <[email protected]> Co-authored-by: Adarsh Shrivastav <[email protected]> Co-authored-by: AmitSinghShorthillsAI <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
make format; make lint
to appease the lint gods