Fix background shading in arrival list

OneBusAway · Jan 12, 2024 · 015b3fa · 015b3fa
1 parent b1b30fa
commit 015b3fa
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 24 deletions.
diff --git a/onebusaway-android/src/main/java/org/onebusaway/android/ui/ArrivalsListFragment.java b/onebusaway-android/src/main/java/org/onebusaway/android/ui/ArrivalsListFragment.java
@@ -1136,7 +1136,7 @@ private void setListViewProperties(int arrivalInfoStyle) {
         listParam.leftMargin = UIUtils.dpToPixels(getActivity(), 5);
         listParam.rightMargin = UIUtils.dpToPixels(getActivity(), 5);
         // Set the listview background to give the cards more contrast
-        getListView().setBackgroundColor(
+        getListView().getRootView().setBackgroundColor(
                 getResources().getColor(R.color.stop_info_arrival_list_background));
         // Update the layout parameters
         getListView().setLayoutParams(listParam);

diff --git a/onebusaway-android/src/main/res/layout/arrivals_list_empty_style.xml b/onebusaway-android/src/main/res/layout/arrivals_list_empty_style.xml
@@ -13,33 +13,35 @@
      See the License for the specific language governing permissions and
      limitations under the License.
 -->
-<LinearLayout
-        xmlns:android="http://schemas.android.com/apk/res/android"
-        android:layout_width="match_parent"
+<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
+    android:layout_width="match_parent"
+    android:layout_height="wrap_content"
+    android:background="@color/stop_info_arrival_list_background"
+    android:orientation="vertical"
+    android:paddingLeft="5dp"
+    android:paddingTop="3dp"
+    android:paddingRight="5dp"
+    android:paddingBottom="2dp">
+
+    <androidx.cardview.widget.CardView xmlns:card_view="http://schemas.android.com/apk/res-auto"
+        android:id="@+id/no_arrivals_card_view"
+        android:layout_width="fill_parent"
         android:layout_height="wrap_content"
-        android:paddingBottom="2dp"
-        android:paddingTop="3dp"
-        android:paddingLeft="5dp"
-        android:paddingRight="5dp"
-        android:orientation="vertical">
+        android:layout_gravity="center"
+        card_view:cardCornerRadius="4dp"
+        card_view:cardUseCompatPadding="true">
 
-    <androidx.cardview.widget.CardView
-            xmlns:card_view="http://schemas.android.com/apk/res-auto"
-            android:id="@+id/no_arrivals_card_view"
-            android:layout_gravity="center"
+        <TextView
+            android:id="@+id/noArrivals"
+            style="@style/ListHintText"
             android:layout_width="fill_parent"
             android:layout_height="wrap_content"
-            card_view:cardUseCompatPadding="true"
-            card_view:cardCornerRadius="4dp">
-
-        <TextView android:id="@+id/noArrivals"
-                  style="@style/ListHintText"
-                  android:paddingBottom="15sp"
-                  android:layout_width="fill_parent"
-                  android:layout_height="wrap_content"/>
+            android:paddingBottom="15sp" />
     </androidx.cardview.widget.CardView>
-    <include layout="@layout/arrivals_list_footer_style"
-             android:layout_width="match_parent"
-             android:layout_height="wrap_content"/>
+
+    <include
+        layout="@layout/arrivals_list_footer_style"
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content" />
 </LinearLayout>