Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Starred Routes list (#354) #1097

Merged
merged 1 commit into from
Dec 17, 2023
Merged

Conversation

millanp
Copy link
Contributor

@millanp millanp commented Dec 3, 2023

I added a new tab below Starred Stops called Starred Routes.

Screenshot from 2023-11-30 21-16-17

It takes you to a list of routes which are starred at at least one stop.

Screenshot from 2023-12-01 20-54-47

A long press on a route shows a popup menu with various options, including an option to remove all stars from that route.

Screenshot from 2023-11-30 21-18-50

There is also a button in the top right menu to remove all stars from all routes.

Screenshot from 2023-12-01 21-24-00

When the user taps one of the starred routes, it shows the map view for that route.

Screenshot from 2023-12-01 21-17-20

This is better than the old method of showing a text-based list of stops because the map is much more readable and it provides useful information about the actual location of buses. Most users I have spoken to do not know that the route-specific map view exists, and they say that it is useful when I show it to them. I modified the "recent routes" list to have similar behavior.

I made one change to existing code, factoring out the classes RouteInfoLoader and RouteInfoLoaderCallback from RouteInfoListFragment into QueryUtils. This is because I need to load the long name of a route when it is starred by the user, to make sure that the Starred Routes page is fully populated.

@CLAassistant
Copy link

CLAassistant commented Dec 3, 2023

CLA assistant check
All committers have signed the CLA.

@aaronbrethorst aaronbrethorst self-assigned this Dec 16, 2023
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great! thanks for building out this feature. I can't wait to get it into the Play Store!

@aaronbrethorst aaronbrethorst merged commit 177bde8 into OneBusAway:master Dec 17, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants