Fixed #895 - Allow saving for routes into the DB #1152
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amr Hossam <[email protected]>
unused import.
Signed-off-by: Amr Hossam <[email protected]>
…sue-895-recent-routes # Conflicts: # onebusaway-android/src/main/java/org/onebusaway/android/util/DBUtil.java
aaronbrethorst
requested changes
Mar 11, 2024
onebusaway-android/src/main/java/org/onebusaway/android/util/DBUtil.java
Outdated
Show resolved
Hide resolved
onebusaway-android/src/main/java/org/onebusaway/android/util/DBUtil.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Amr Hossam <[email protected]>
onebusaway-android/src/main/java/org/onebusaway/android/util/DBUtil.java
Show resolved
Hide resolved
|
I'm going to merge this in PR #1175 because GitHub is complaining about merge conflicts. 
|
|
Thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #895
Details
After a couple of hours investigating the issue and the DB and trying to debug the saving into the DB, I found that class
ObaContractis responsible for the CRUD operations and after reviewing the class code I found that an inner class calledRoutesthat was having a function calledInsertOrUpdateand sure the class responsible for managingCRUDoperations of recent routes and I found that this method isn't used when showing a route on the map / showing trip statues / searching for a route and of course, saving will not work in this case.Fix
I wrote two functions in the
DBUtilclass that will work to save the route when showing it showing trip statues / or clicking on the route in search results. and called this function when all of these operations are used and now it's working perfectly.Video showing trying different test cases
Screencast.from.03-09-2024.01.47.30.PM.webm
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
gradlew connectedObaGoogleDebugAndroidTestto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them for the initial submission of the pull request. When addressing comments on a pull request, please push a new commit per comment when possible (reviewers will squash and merge using GitHub merge tool)