Fixed #1163 - Restoring backup crash. #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amr Hossam <[email protected]>
|
|
aaronbrethorst
approved these changes
Mar 15, 2024
| @@ -402,7 +402,9 @@ public void onRequestPermissionsResult( | |||
| protected void onActivityResult(int requestCode, int resultCode, Intent data) { | |||
| super.onActivityResult(requestCode, resultCode, data); | |||
| if (requestCode == REQUEST_CODE_RESTORE_BACKUP) { | |||
| BackupUtils.restore(this, data.getData()); | |||
| if(data != null){ | |||
There was a problem hiding this comment.
this is super-nitpicky, but please watch your spacing:
if (data != null) {
You might also consider combining your control flow statements, either as
requestCode == REQUEST_CODE_RESTORE_BACKUP && data != null
or as
requestCode != REQUEST_CODE_RESTORE_BACKUP || data == null
for an early return.
There was a problem hiding this comment.
Yes this is a much better thanks for correcting me !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1163.
Details
The issue was about the
onActivityResultmethod. TheonActivityResultmethod is a callback method in an Android Activity class that gets called automatically when another activity launched by the current activity exits, delivering a result back to it. This method is used to handle the result returned by the child activity. so the method was responsible for getting the data from theFile picker activityabout ourbackup-file, when we go back and do not select any file we get anull expection.Fix
Added validation for null data that returns.
Video
Screencast.from.03-11-2024.01.44.48.PM.webm
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
gradlew connectedObaGoogleDebugAndroidTestto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them for the initial submission of the pull request. When addressing comments on a pull request, please push a new commit per comment when possible (reviewers will squash and merge using GitHub merge tool)