-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed #981 #1285
fixed #981 #1285
Conversation
@aaronbrethorst I have signed the CLA, still it says that it is pending |
@viditpawar0 I don't know why it says you haven't signed it, but I do see that you have completed it from the admin console. fyi @amrhossamdev |
Hi @viditpawar0 Thank you for your contribution. I will test that and get back to you! |
Hi @viditpawar0, thank you for your contribution! I have tested the functionality, and it works perfectly. I will request code changes from you, and it will be ready for merging. |
onebusaway-android/src/main/java/org/onebusaway/android/ui/TripPlanFragment.java
Outdated
Show resolved
Hide resolved
onebusaway-android/src/main/java/org/onebusaway/android/ui/TripPlanFragment.java
Outdated
Show resolved
Hide resolved
onebusaway-android/src/main/java/org/onebusaway/android/ui/TripPlanFragment.java
Outdated
Show resolved
Hide resolved
onebusaway-android/src/main/java/org/onebusaway/android/ui/TripPlanFragment.java
Outdated
Show resolved
Hide resolved
onebusaway-android/src/main/java/org/onebusaway/android/ui/TripPlanFragment.java
Outdated
Show resolved
Hide resolved
…for readability
Thank you so much @amrhossamdev for taking time to review my code and provide insights. I have made the necessary changes. The reason I referred to the address text view in the |
Great job, @viditpawar0! Your work is fantastic! I did notice a small bug: when I select an address for the "starting address" from my contacts, it works perfectly, and the address is set correctly. However, when I select an address for the "ending address," it removes the "starting address" from the input field. And vice versa. Could you please take a look at this? Let me know if you need any assistance! |
Sure @amrhossamdev , that bug is solved in this commit. |
Well done, @viditpawar0. Another thing: you should request to submit to plan the trip after selecting the |
Okay, @amrhossamdev I will need a little assistance on that, do I need to call the |
@viditpawar0 Yes, and we need to make sure that we have the |
@amrhossamdev I will need the api.geocode.earth API to test that which is not working on my device. Here is the http response: This is happening while using the Please help me with this. |
@viditpawar0 Can you push your changes? |
@amrhossamdev sure. |
…ng the to address
@amrhossamdev There you go. But note that this change is un-tested because the geocode api is not working on my device |
Thanks, @viditpawar0 I will test that! |
Welcome, @amrhossamdev ! |
…ng the to address
Signed-off-by: Amr Hossam <[email protected]>
Signed-off-by: Amr Hossam <[email protected]>
Great work, @viditpawar0 ! 🥳 I made a couple of minor changes. When we select an address from the contacts, we will request Additionally, I have fixed some minor bugs in the trip planning UI. Overall, fantastic job, and thank you for your contribution! This pull request is ready to merge. |
@amrhossamdev awesome🤩! I'm excited. |
Signed-off-by: Amr Hossam <[email protected]>
Hi @viditpawar0, could you ensure you signed the I See you have two accounts 🤔 @arctik-circle and @viditpawar0 could you ensure both signed |
@amrhossamdev sure, done. Signed CLA from both accounts |
LGTM, well done 🫡 |
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
AndroidStyle.xml
style template to your code in Android Studio.Run the unit tests with
gradlew connectedObaGoogleDebugAndroidTest
to make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them for the initial submission of the pull request. When addressing comments on a pull request, please push a new commit per comment when possible (reviewers will squash and merge using GitHub merge tool)
Fixed #981
Summary of changes: -
mSelectAddressFromContactLauncher
inTripPlanFragment
that can be used to get the user select a contact and set the address from the contact to the text field.fragment_trip_plan.xml
.Screenshots of UI Changes: -