Fix #237 - If custom url reporting disabled when it is null. #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cagryInside
commented
Mar 4, 2015
cagryInside
commented
- Api region reporting removed from MapStopIcon event as discussed in StopInfo event reported for incorrect button press in master branch #233 (comment).
- Agreed to keep OBA Android consistent with OBA Iphone as discussed in Including custom URLs when reporting events with GA. #237 (comment). So, the following differences added:
- Turned on Experimental Regions
- Turned off Experimental Regions
- Set region manually
| ObaAnalytics.reportEventWithCategory(ObaAnalytics.ObaEventCategory.UI_ACTION.toString(), | ||
| getString(R.string.analytics_action_button_press), | ||
| getString(R.string.analytics_label_button_press_experimental) + experimentalServers); | ||
| if (experimentalServers) |
There was a problem hiding this comment.
@cagryInside Could you please add braces{ to this IF statement? As a matter of style I prefer to always use them. Also, you might want to check if you have the "reformat code" checkbox checked in the "Commit Changes" view in Android Studio. I think the style template should have automatically reformatted this to include braces.
|
Thanks @cagryInside! Mostly looks good - one request in-line. |
|
@barbeau thanks. I will make the same changes in develop branch too. |
|
Thanks! |
Also Api region reporting removed from MapStopIcon event as discussed in OneBusAway#233 (comment).
|
@cagryInside I think this should be good to be merged now? |
|
@barbeau agreed. Thanks. |
barbeau
added a commit
that referenced
this pull request
Mar 5, 2015
Fix #237 - If custom url reporting disabled when it is null.
|
Great, thanks @cagryInside! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.