Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strategy to update stop.vehicle_types #146

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hbruch
Copy link
Contributor

@hbruch hbruch commented Apr 12, 2020

Summary:
The optional extension field stop.vehicle_type indicates which route_types are served at a stop. It may be used e.g. to visualize stops in maps accordingly.

This strategy collects all route_types via all stop_times/trips at each individual stop. In case multiple route_types are served, it tries to map extended route_types to GTFS standard route_types. If still then route_types are inconsistent, a missing value of -999 is set.

  • Run the unit tests with mvn test to make sure you didn't break anything
  • Format the title like "Fix #<issue_number> - short description of fix and changes" (unchecked, as this is not a fix)
  • Linked all relevant issues (unchecked, as searching for vehicle_type did not list any relevant issues)
  • Added unit test for new functionality

@CLAassistant
Copy link

CLAassistant commented Apr 12, 2020

CLA assistant check
All committers have signed the CLA.

@leonardehrenfried
Copy link
Collaborator

leonardehrenfried commented Sep 2, 2024

Hello, I'm the new maintainer of this library and will do a bit of renovation work.

If you're still interested in getting this merged, can you rebase it onto the latest master? You will probably need to change a few imports in the test since I migrated to Junit 5.

@leonardehrenfried leonardehrenfried changed the title Adds strategy to update stop.vehicle_types Add strategy to update stop.vehicle_types Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants