-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Haoyue fix team code data on profile page #2751
base: development
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After replacing the team code in weekly summary reports and back to the profile page. The edit button exists but when I want to update the team code, it displays "invalid team code error". Please check more details in my video.
bandicam.2024-10-11.23-46-27-568.mp4
bandicam.2024-10-11.23-43-40-636.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I reviewed PR #2751. I pulled the latest version to my local and checked the fixed function. The function works as expected. I modified the team code from AB-XYZ to A-XYZ, then went to the profile. The styling of the title div and the team code field in the edit modal, appeared as red.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested this code, I have changed the team code from B-TES to B-tesss in the weekly summary report section. The code is updated successfully. But when i am trying to update the code in profile section, i cannot see the EDIT button to update the existing team code. But it is working fine when i am trying to create a new title with changed code B-tesss, i can see the changed code in the dropdown list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f762071
Hi @Jingyii800, I’ve tested this issue multiple times but haven’t been able to replicate the bug. Could you please clear your browser cache and double-check if the issue still persists? Let me know if you encounter it again. Thank you! |
Description
Related PRS (if any):
To test this frontend PR you need to checkout the #1194 backend PR.
Main changes explained:
…
How to test:
npm install
and...
to run this PR locallyScreenshots or videos of changes:
Screen.Recording.2024-10-04.at.10.35.05.PM.mov