Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haoyue fix team code data on profile page #2751

Open
wants to merge 6 commits into
base: development
Choose a base branch
from

Conversation

oliviahyw
Copy link
Contributor

@oliviahyw oliviahyw commented Oct 5, 2024

Description

Screenshot 2024-10-04 at 10 49 18 PM

Related PRS (if any):

To test this frontend PR you need to checkout the #1194 backend PR.

Main changes explained:

  • Changed the options in "Team Code" field on profile page to the active team code data from the weekly summary report page.
  • Added team code to redux so that it can be accessed through the entire app.
  • When the team code has been updated on the weekly summary report page, the according title on the profile page will display as red.
  • Also added the error styling for the team code field.

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to user profile → Add a New Title
  6. verify the current team code
  7. go to weekly summary report → modify the team code
  8. go to user profile → verify the styling of title div and team code field in the edit modal

Screenshots or videos of changes:

Screen.Recording.2024-10-04.at.10.35.05.PM.mov

Copy link

netlify bot commented Oct 5, 2024

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit e9654c8
🔍 Latest deploy log https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/6778b0bc3f741a0008b5dc0a
😎 Deploy Preview https://deploy-preview-2751--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Hritvik111 Hritvik111 added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Oct 9, 2024
Copy link
Contributor

@Jingyii800 Jingyii800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After replacing the team code in weekly summary reports and back to the profile page. The edit button exists but when I want to update the team code, it displays "invalid team code error". Please check more details in my video.

bandicam.2024-10-11.23-46-27-568.mp4
bandicam.2024-10-11.23-43-40-636.mp4

AshishNags
AshishNags previously approved these changes Oct 17, 2024
Copy link
Contributor

@AshishNags AshishNags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this PR, Functionality working as expected.
Screenshot 2024-10-17 121736
Screenshot 2024-10-17 121859
Screenshot 2024-10-17 122420

Screenshot 2024-10-17 122545

@VMD281
Copy link

VMD281 commented Oct 19, 2024

Hi, I reviewed this PR and the alignment looks good! I have pasted the screenshots below:
PR#2751_1
PR#2751_2
PR#2751_3
PR#2751_4
PR#2751_5

samarth9201
samarth9201 previously approved these changes Oct 23, 2024
Copy link
Contributor

@samarth9201 samarth9201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the functionality of the PR. LGTM!

image

Copy link

@bhavya17prakash bhavya17prakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the functionality is working as intended
PR 2751

Copy link

@Rui-Liu-github Rui-Liu-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I reviewed PR #2751. I pulled the latest version to my local and checked the fixed function. The function works as expected. I modified the team code from AB-XYZ to A-XYZ, then went to the profile. The styling of the title div and the team code field in the edit modal, appeared as red.
ReviewPR_#2751_1
ReviewPR_#2751_2
ReviewPR_#2751_3
ReviewPR_#2751_4
ReviewPR_#2751_5
ReviewPR_#2751_6

zhiminV
zhiminV previously approved these changes Oct 26, 2024
Copy link

@zhiminV zhiminV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked this function works as expected. I changed the team code from a-bbb to AbbAbb, it work after I changed and I back to the profile, the new team code also showed in the dropdown list.
Screenshot 2024-10-26 at 1 40 54 PM
Screenshot 2024-10-26 at 1 39 22 PM
Screenshot 2024-10-26 at 1 41 01 PM
Screenshot 2024-10-26 at 1 43 57 PM

Copy link

@AshritaCherlapally AshritaCherlapally left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this code, I have changed the team code from B-TES to B-tesss in the weekly summary report section. The code is updated successfully. But when i am trying to update the code in profile section, i cannot see the EDIT button to update the existing team code. But it is working fine when i am trying to create a new title with changed code B-tesss, i can see the changed code in the dropdown list.

Screenshot 2024-11-02 at 3 12 29 PM Screenshot 2024-11-02 at 3 12 44 PM Screenshot 2024-11-02 at 3 18 18 PM

Copy link

@ajitp4292 ajitp4292 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked the functionality works as expected. I changed the team code from T-est to T-est1, it work after I changed and I back to the profile, the new team code also showed in the
Screenshot 2024-11-02 at 4 40 35 PM
Screenshot 2024-11-02 at 4 44 52 PM
list.

@sheetalmangate
Copy link
Contributor

Could not test this PR locally. after checkout to branch "haoyue-team-code-data" its giving below error while starting a project.

PR2751_testing_error

sheetalmangate
sheetalmangate previously approved these changes Nov 3, 2024
Copy link
Contributor

@sheetalmangate sheetalmangate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this PR locally. its is working as expected so approving it

PR2751_testing1

Copy link
Contributor

@SupriyaSudini SupriyaSudini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this PR and confirmed that the team code has been replaced. However, the edit button is missing in the profile section, and the replaced team code is visible when creating a new title.

image

image

image

image

Copy link

@Muhideenthegreat Muhideenthegreat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verification:

  • Functionality works as expected, only active team codes are in yellow
Screenshot 2024-11-08 at 6 34 39 PM Screenshot 2024-11-08 at 6 35 38 PM Screenshot 2024-11-08 at 6 36 26 PM

@oliviahyw
Copy link
Contributor Author

After replacing the team code in weekly summary reports and back to the profile page. The edit button exists but when I want to update the team code, it displays "invalid team code error". Please check more details in my video.

bandicam.2024-10-11.23-46-27-568.mp4
bandicam.2024-10-11.23-43-40-636.mp4

Hi @Jingyii800, I’ve tested this issue multiple times but haven’t been able to replicate the bug. Could you please clear your browser cache and double-check if the issue still persists? Let me know if you encounter it again. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.