fix: to token detail price ok-34763

[ezailWang]

Summary by CodeRabbit

• Refactor

  • Improved token detail loading logic in swap functionality
  • Enhanced state update mechanism for token selection process
  • Refined conditional checks for token processing

• Code Quality

  • Streamlined method implementation for better readability and maintainability

[codesandbox]

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

[coderabbitai]

Walkthrough

The pull request modifies the loadSwapSelectTokenDetail method in the swap actions context. The changes focus on refining the token detail loading logic by simplifying the conditional check for token processing. The update introduces a more flexible approach to handling tokens, particularly those without a defined price. The code's structure remains consistent, with improvements aimed at enhancing readability and reducing potential error points during state updates.

Changes

File	Change Summary
packages/kit/src/states/jotai/contexts/swap/actions.ts	- Updated loadSwapSelectTokenDetail method logic - Simplified conditional check for token processing - Introduced temporary condition object for state updates - Refined token detail loading approach

Sequence Diagram

sequenceDiagram
    participant Method as loadSwapSelectTokenDetail
    participant Condition as Token Condition Check
    participant State as State Update
    
    Method->>Condition: Check token validity
    Condition-->>Method: Validate token
    Method->>State: Create temporary condition object
    State->>State: Update state with token details

Loading

The sequence diagram illustrates the refined flow of token detail loading, highlighting the simplified validation and state update process introduced in the changes.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary or Summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 188a524 and 16414ac.

📒 Files selected for processing (1)

• packages/kit/src/states/jotai/contexts/swap/actions.ts (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: lint (20.x)

🔇 Additional comments (1)

packages/kit/src/states/jotai/contexts/swap/actions.ts (1)

1319-1361: Great refactoring of state updates!

The use of a temporary condition object to collect updates before applying them to the state is a clean pattern that:

• Makes the code more maintainable
• Reduces the chance of state update errors
• Improves readability with clear property assignments

[coderabbitai]

🧹 Nitpick (assertive)

Improve condition readability.

The condition logic is correct but could be more readable. Consider extracting the conditions into descriptive variables.

-      if (
-        (token &&
-          accountAddress &&
-          accountNetworkId &&
-          accountNetworkId === token?.networkId) ||
-        (!token?.price && token)
-      ) {
+      const hasValidAccountInfo = token && accountAddress && accountNetworkId && accountNetworkId === token?.networkId;
+      const isTokenWithoutPrice = !token?.price && token;
+      if (hasValidAccountInfo || isTokenWithoutPrice) {

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	(token &&
	accountAddress &&
	accountNetworkId &&
	accountNetworkId === token?.networkId) ||
	(!token?.price && token)
	const hasValidAccountInfo = token && accountAddress && accountNetworkId && accountNetworkId === token?.networkId;
	const isTokenWithoutPrice = !token?.price && token;
	if (hasValidAccountInfo || isTokenWithoutPrice) {