Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixe the issue of the soft keyboard closing automatically & fix text truncation issues.(OK-35362) #6596

Open
wants to merge 3 commits into
base: x
Choose a base branch
from

Conversation

huhuanming
Copy link
Contributor

@huhuanming huhuanming commented Jan 23, 2025

Summary by CodeRabbit

  • Performance Improvements
    • Enhanced page navigation interaction by optimizing keyboard dismissal logic.
    • Introduced more precise tracking of page index selection to reduce unnecessary UI interruptions.
  • New Features
    • Improved text wrapping behavior in the Button component to better handle Chinese punctuation and prevent text truncation.

before:
image

after:
image

Copy link

codesandbox bot commented Jan 23, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link
Contributor

coderabbitai bot commented Jan 23, 2025

Walkthrough

The changes modify the HomePageView component by introducing a prevPageIndex reference variable to track the previously selected page index. The primary goal is to optimize keyboard dismissal logic, ensuring that the keyboard is only dismissed when the page index actually changes. This refinement prevents unnecessary keyboard interactions and improves the user experience by making page navigation more precise.

Changes

File Change Summary
packages/kit/.../HomePageView.tsx Added prevPageIndex using useRef to track previous page index and conditionally manage keyboard dismissal.
packages/components/.../Button/index.tsx Added textBreakStrategy prop to SizableText component for improved text wrapping and display of Chinese punctuation. Commented out previous textAlign prop.

Sequence Diagram

sequenceDiagram
    participant User
    participant HomePageView
    participant Keyboard

    User->>HomePageView: Select Page Index
    HomePageView->>HomePageView: Compare Current vs Previous Index
    alt Index Changed
        HomePageView->>Keyboard: Dismiss Keyboard
    else Index Same
        HomePageView->>Keyboard: No Action
    end
Loading

The sequence diagram illustrates how the new implementation checks the page index before deciding whether to dismiss the keyboard, adding a layer of intelligent interaction management.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f097abe and 1803e5e.

📒 Files selected for processing (1)
  • packages/components/src/primitives/Button/index.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: lint (20.x)
  • GitHub Check: Analyze (javascript-typescript)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary or Summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@huhuanming huhuanming enabled auto-merge (squash) January 23, 2025 13:13
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e10d090 and f097abe.

📒 Files selected for processing (1)
  • packages/kit/src/views/Home/pages/HomePageView.tsx (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: lint (20.x)
  • GitHub Check: Analyze (javascript-typescript)

@huhuanming huhuanming changed the title fix: fixed the issue of the soft keyboard closing automatically. fix: fixe the issue of the soft keyboard closing automatically & fix text truncation issues. Jan 23, 2025
@huhuanming huhuanming changed the title fix: fixe the issue of the soft keyboard closing automatically & fix text truncation issues. fix: fixe the issue of the soft keyboard closing automatically & fix text truncation issues.(OK-35362) Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant