-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixe the issue of the soft keyboard closing automatically & fix text truncation issues.(OK-35362) #6596
base: x
Are you sure you want to change the base?
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
WalkthroughThe changes modify the Changes
Sequence DiagramsequenceDiagram
participant User
participant HomePageView
participant Keyboard
User->>HomePageView: Select Page Index
HomePageView->>HomePageView: Compare Current vs Previous Index
alt Index Changed
HomePageView->>Keyboard: Dismiss Keyboard
else Index Same
HomePageView->>Keyboard: No Action
end
The sequence diagram illustrates how the new implementation checks the page index before deciding whether to dismiss the keyboard, adding a layer of intelligent interaction management. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
packages/kit/src/views/Home/pages/HomePageView.tsx
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: lint (20.x)
- GitHub Check: Analyze (javascript-typescript)
Summary by CodeRabbit
before:
after: