Merge pull request #2132 from OneSignal/fix/NotificationPermissionCon…

…troller_methods [fix] NotificationPermissionController fix an override method signature
OneSignal · Jun 18, 2024 · e367bd9 · e367bd9
2 parents 6e65b5f + 9482a93
commit e367bd9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/...com/onesignal/notifications/internal/permissions/impl/NotificationPermissionController.kt b/...com/onesignal/notifications/internal/permissions/impl/NotificationPermissionController.kt
@@ -87,8 +87,8 @@ internal class NotificationPermissionController(
     private fun registerPollingLifecycleListener() {
         _applicationService.addApplicationLifecycleHandler(
             object : ApplicationLifecycleHandlerBase() {
-                override fun onFocus() {
-                    super.onFocus()
+                override fun onFocus(firedOnSubscribe: Boolean) {
+                    super.onFocus(firedOnSubscribe)
                     pollingWaitInterval = _configModelStore.model.foregroundFetchNotificationPermissionInterval
                     pollingWaiter.wake()
                 }

diff --git a/.../com/onesignal/notifications/internal/permission/NotificationPermissionControllerTests.kt b/.../com/onesignal/notifications/internal/permission/NotificationPermissionControllerTests.kt
@@ -61,7 +61,7 @@ class NotificationPermissionControllerTests : FunSpec({
         // call onFocus to set the proper polling interval.
         // This happens when registering the lifecycle handler
         for (focusHandler in focusHandlerList) {
-            focusHandler.onFocus()
+            focusHandler.onFocus(false)
         }
 
         // When
@@ -99,7 +99,7 @@ class NotificationPermissionControllerTests : FunSpec({
         // call onFocus to set the proper polling interval.
         // This happens when registering the lifecycle handler
         for (focusHandler in handlerList) {
-            focusHandler.onFocus()
+            focusHandler.onFocus(false)
         }
 
         // When
@@ -142,7 +142,7 @@ class NotificationPermissionControllerTests : FunSpec({
         // call onFocus to set the proper polling interval.
         // This happens when registering the lifecycle handler
         for (focusHandler in handlerList) {
-            focusHandler.onFocus()
+            focusHandler.onFocus(false)
         }
 
         // When
@@ -156,7 +156,7 @@ class NotificationPermissionControllerTests : FunSpec({
         delay(100)
         // the app regains focus
         for (handler in handlerList) {
-            handler.onFocus()
+            handler.onFocus(false)
         }
         delay(5)