Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to Gradle 8 and AGP 8 #2209

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jkasten2
Copy link
Member

@jkasten2 jkasten2 commented Oct 31, 2024

Description

One Line Summary

Update both SDK project and example to use the latest Gradle and AGP (Android Gradle Plugin) versions, currently 8.x.

Details

Motivation

Our Gradle version and AGP versions are getting out of date. It is starting to cause issues such as having to configure a system JDK of 17 instead of using 21 that ships with the newest Android Studio. Updating before trying to automate publishing, as otherwise we will test publishing again.

Scope

Only changes require to build with the latest Gradle and AGP versions.

Testing

Unit testing

  • TODO - Publishing is untested and may require some changes yet.

Manual testing

Ensured example project builds and runs on an Android emulator.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

Publishing is untested and may require some changes yet.
@jkasten2 jkasten2 added the WIP Work In Progress label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work In Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant