This repository has been archived by the owner on Oct 31, 2022. It is now read-only.
Downgrade work-runtime to 2.6.0 if compileSdkVersion 30 or older is used #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two new tests fail on this commit and were added to show the issue We will make them pass in the next commit in this PR.
Moving into helper method as we will utilize this in the next commit
Downgrade `work-runtime` to 2.6.0 if the app's `compileSdkVersion` is 30 or lower. This prevents build errors when AGP runs the task `checkDebugAarMetadata`
This is required due the test 'Find min-support for Firebase and GMS - build' being fragile and failing due to a new Google library being available. Its pulling in `worker-runtime:2.7.0` from `play-services-ads:+` -> `play-services-ads-lite:20.5.0`.
Set a version range for the `work-runtime` rule so it doesn't cause it to be unintentionally upgraded. Added tests to ensure the senario is covered.
jkasten2
requested review from
adamschlesinger,
jmadler,
nan-li,
rgomezp and
Jeasmine
nan-li
approved these changes
Nov 23, 2021
Base automatically changed from
fix/tests_for_new_onesignal_version_3.16.1
to
main
November 23, 2021 20:15
jkasten2
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fixes tasks
:app:checkDebugAarMetadataandcheckReleaseAarMetadatafailing at build time when a project haswork-runtime:2.7.0(OneSignal-Android-SDK 4.6.2 uses this) andcompileSdkVersion 30or older.What is the build error output
Scope
Only affects app projects that contain
work-runtime. Whether that is directly or indirectly through a dependency.How was this implemented?
By checking for the app project's
compileSdkVersionand defining a max version of2.6.+forwork-runtimeifcompileSdkVersionis 30 or less.Issues this fixes
This change is