Skip to content

Commit

Permalink
fixup! clean up comments referring to subdomain feature
Browse files Browse the repository at this point in the history
  • Loading branch information
jkasten2 committed Nov 23, 2023
1 parent aed1bc0 commit 0e24810
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
6 changes: 2 additions & 4 deletions src/shared/managers/SubscriptionManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,8 @@ export class SubscriptionManager {
/**
* Subscribes for a web push subscription.
*
* This method is aware of different subscription environments like subscribing from a webpage,
* service worker, or OneSignal HTTP popup and will select the correct method. This is intended to
* be the single public API for obtaining a raw web push subscription (i.e. what the browser
* returns from a successful subscription).
* This method can be called from the page context or a webpage a service worker context
* and will select the correct method.
*/
public async subscribe(
subscriptionStrategy: SubscriptionStrategyKind,
Expand Down
3 changes: 1 addition & 2 deletions src/shared/models/Subscription.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ export class Subscription implements Serializable {
*/
createdAt: number | undefined;
/**
* For HTTP sites only. This property is stored on the native PushSubscription object, but it's inaccessible
* in cross-origin frames.
* This property is stored on the native PushSubscription object.
*/
expirationTime: number | null | undefined;

Expand Down

0 comments on commit 0e24810

Please sign in to comment.