move noUnusedLocals=true from IDE to compile

Adjusted a few files that didn't follow this rule to get it to compile.
OneSignal · Sep 20, 2024 · aec2837 · aec2837
1 parent 7602f41
commit aec2837
Show file tree

Hide file tree

Showing 7 changed files with 2 additions and 10 deletions.
diff --git a/build/config/tsconfig.base.json b/build/config/tsconfig.base.json
@@ -8,7 +8,7 @@
     "noImplicitAny": false,
     "noImplicitReturns": true,
     "noImplicitThis": true,
-    "noUnusedLocals": false,
+    "noUnusedLocals": true,
     "noUnusedParameters": false,
     "allowSyntheticDefaultImports": true,
     "allowUnreachableCode": false,

diff --git a/src/page/bell/Bell.ts b/src/page/bell/Bell.ts
@@ -494,9 +494,7 @@ export default class Bell {
 
     const isPushEnabled =
       await OneSignal.context.subscriptionManager.isPushNotificationsEnabled();
-    const doNotPrompt = DismissHelper.wasPromptOfTypeDismissed(
-      DismissPrompt.Push,
-    );
+    DismissHelper.wasPromptOfTypeDismissed(DismissPrompt.Push);
 
     // Resize to small instead of specified size if enabled, otherwise there's a jerking motion
     // where the bell, at a different size than small, jerks sideways to go from large -> small or medium -> small

diff --git a/src/page/bell/Dialog.ts b/src/page/bell/Dialog.ts
@@ -1,5 +1,3 @@
-import bowser from 'bowser';
-
 import OneSignalEvent from '../../shared/services/OneSignalEvent';
 import SdkEnvironment from '../../shared/managers/SdkEnvironment';
 import {

diff --git a/src/page/managers/PromptsManager.ts b/src/page/managers/PromptsManager.ts
@@ -6,7 +6,6 @@ import {
 } from '../../shared/config/constants';
 import { DismissHelper } from '../../shared/helpers/DismissHelper';
 import InitHelper from '../../shared/helpers/InitHelper';
-import MainHelper from '../../shared/helpers/MainHelper';
 import PromptsHelper from '../../shared/helpers/PromptsHelper';
 import Log from '../../shared/libraries/Log';
 import {

diff --git a/src/shared/helpers/EventHelper.ts b/src/shared/helpers/EventHelper.ts
@@ -1,4 +1,3 @@
-import OneSignalApiShared from '../api/OneSignalApiShared';
 import Log from '../libraries/Log';
 import { CustomLinkManager } from '../managers/CustomLinkManager';
 import { ContextSWInterface } from '../models/ContextSW';

diff --git a/src/shared/utils/utils.ts b/src/shared/utils/utils.ts
@@ -1,6 +1,5 @@
 import SdkEnvironment from '../managers/SdkEnvironment';
 import { WindowEnvironmentKind } from '../models/WindowEnvironmentKind';
-import Database from '../services/Database';
 import { OneSignalUtils } from './OneSignalUtils';
 import { PermissionUtils } from './PermissionUtils';
 import { Utils } from '../context/Utils';

diff --git a/tsconfig.json b/tsconfig.json
@@ -10,7 +10,6 @@
     "strictNullChecks": true,
     "checkJs": true,
     "noImplicitAny": true,
-    "noUnusedLocals": true,
     "noUnusedParameters": true,
     "strictPropertyInitialization": true,
     "baseUrl": ".",