Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OneSignal SDK is not compatible with this browser on Safari Mobile #1126

Closed
MakhBeth opened this issue Nov 10, 2023 · 2 comments · Fixed by #1135
Closed

OneSignal SDK is not compatible with this browser on Safari Mobile #1126

MakhBeth opened this issue Nov 10, 2023 · 2 comments · Fixed by #1135

Comments

@MakhBeth
Copy link

MakhBeth commented Nov 10, 2023

Hello!

Currently on Safari iOS the SDK doesn't load at all.

Since web ios notifications for safari mobile have been implemented by Apple.

Will this also help us with the mobile safari?

Currently I'm getting this in mobile safari:

image

(This is with installing a build yarn build:prod and moving these bundled files to the public folder root)

Am I missing something?

@jkasten2

iOS WebApp Push

iOS WebPush was missing in the v16 branch (AKA v11 OneSignal docs). We merged in the missing feature from main and just released a Beta 6 today: https://github.com/OneSignal/OneSignal-Website-SDK/releases/tag/160000.beta6

Migration guide

We fixed the wording in the migration guide around the service worker. Let us know if this is clear now: https://github.com/OneSignal/OneSignal-Website-SDK/blob/160000.beta6/MIGRATION_GUIDE.md#service-worker

Originally posted by @BramDecuypere in #619 (comment)

@jkasten2
Copy link
Member

jkasten2 commented Nov 14, 2023

@MakhBeth Thanks for the question, it requires installing your site as a Web App, see Mobile Web Push for iOS/iPadOS.

  • We also updated the release notes to make this more clear as well.

We will look into seeing if we can improve the "SDK is not compatible with this browser" message to point out this requirement.

@MakhBeth
Copy link
Author

Thanks @jkasten2. Yes a better message will surely improve DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants