Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Show iOS supported message #1135

Merged
merged 3 commits into from
Nov 17, 2023
Merged

Conversation

jkasten2
Copy link
Member

@jkasten2 jkasten2 commented Nov 15, 2023

Description

1 Line Summary

Improve DX for not supported browser since it can be confusing for iOS.

Details

Validation

Tests

Tested to ensure new "...To support iOS please install as a Web App. See the OneSignal guide https://documentation.onesignal.com/docs/safari-web-push-for-ios" shows on an iPhone running iOS 16.7.2 in the JS console when using Safari.

Info

Checklist

  • All the automated tests pass or I explained why that is not possible
  • I have personally tested this on my machine or explained why that is not possible
  • I have included test coverage for these changes or explained why they are not needed

Programming Checklist
Interfaces:

  • Don't use default export
  • New interfaces are in model files

Functions:

  • Don't use default export
  • All function signatures have return types
  • Helpers should not access any data but rather be given the data to operate on.

Typescript:

  • No Typescript warnings
  • Avoid silencing null/undefined warnings with the exclamation point

Other:

  • Iteration: refrain from using elem of array syntax. Prefer forEach or use map
  • Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Info

Checklist

  • I have included screenshots/recordings of the intended results or explained why they are not needed

Related Tickets

Fixes #1126



This change is Reviewable

These helper functions will be used in a follow up commit
Also removed Firefox ESR message as this build supports push now.
@jkasten2 jkasten2 requested review from rgomezp and emawby November 15, 2023 19:50
@jkasten2 jkasten2 merged commit fd46f19 into main Nov 17, 2023
4 checks passed
@jkasten2 jkasten2 deleted the feat/show_ios_supported_message branch November 17, 2023 18:07
@jkasten2 jkasten2 mentioned this pull request Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OneSignal SDK is not compatible with this browser on Safari Mobile
2 participants