Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to node 18 #1109

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Upgrade to node 18 #1109

merged 3 commits into from
Sep 29, 2023

Conversation

jkasten2
Copy link
Member

@jkasten2 jkasten2 commented Sep 29, 2023

Description

1 Line Summary

Update from Node 14 to Node 18 (LTS).

Details

Updated node versions used in docker and the CI / CD process. Had to upgrade to bundlesize2 as bundlesize was incompatible with node 18.

Validation

Tests

Tested yarn build:dev-prod ensuring it works with Chrome on Windows to subscribe and get a notification.
Ensured yarn build:prod builds and bundlesize detects going over its size limit. yarn lint and yarn test pass as well.

Checklist

  • All the automated tests pass or I explained why that is not possible
  • I have personally tested this on my machine or explained why that is not possible
  • I have included test coverage for these changes or explained why they are not needed

Programming Checklist
Interfaces:

  • Don't use default export
  • New interfaces are in model files

Functions:

  • Don't use default export
  • All function signatures have return types
  • Helpers should not access any data but rather be given the data to operate on.

Typescript:

  • No Typescript warnings
  • Avoid silencing null/undefined warnings with the exclamation point

Other:

  • Iteration: refrain from using elem of array syntax. Prefer forEach or use map
  • Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Info

Checklist

  • I have included screenshots/recordings of the intended results or explained why they are not needed

Related Tickets



This change is Reviewable

Updated to the latest available LTS.
Introduced .nvmrc file to share the node version between cd / ci files.
This wasn't bundlesize was not compatible with node 18 so had to update
to this new package.

yarn.lock contains changes to both update to node 18 and switching to
the bundlesize2 package.
This new node interface was conflicting with our Disposable so renamed
ours to OSDisposable.
@jkasten2 jkasten2 requested a review from rgomezp September 29, 2023 02:09
@jkasten2 jkasten2 merged commit 68846f8 into main Sep 29, 2023
2 checks passed
@jkasten2 jkasten2 deleted the upgrade-to-node18 branch September 29, 2023 22:00
rgomezp added a commit that referenced this pull request Jul 10, 2024
rgomezp added a commit that referenced this pull request Jul 10, 2024
Motivation:
- upgrade node to 18
- fix CI/cd
- commit yarn.lock
rgomezp added a commit that referenced this pull request Jul 10, 2024
Motivation:
- upgrade node to 18
- fix CI/cd
- commit yarn.lock
rgomezp added a commit that referenced this pull request Jul 10, 2024
Motivation:
- upgrade node to 18
- fix CI/cd
- commit yarn.lock
rgomezp added a commit that referenced this pull request Jul 10, 2024
Motivation:
- upgrade node to 18
- fix CI/cd
- commit yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants