[Fix] Address all CodeQL scan results #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkasten2
force-pushed
the
fix/scan-results
branch
from
77f1a0d to
de428a1
Compare
Remove dead getUrlQueryParam in SDK code, and also improve implementation in example project
This is no longer needed as all browsers in the past few years have window.crypto now. Also removed duplicate test implementation of getRandomUuid().
These are not needed as has a risk of leaking package.json details
This code will be removed in the near future
Instead of innerHTML when value comes from the DOM or user input
jkasten2
force-pushed
the
fix/scan-results
branch
from
072f5a8 to
17e2042
Compare
jkasten2
changed the title
emawby
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, 1 of 1 files at r4, 3 of 3 files at r5, 3 of 3 files at r6, 3 of 3 files at r7, 3 of 3 files at r8, 1 of 1 files at r9, 1 of 1 files at r10, 4 of 4 files at r11, 1 of 1 files at r12, 1 of 1 files at r13, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @iAmWillShepherd and @rgomezp)
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1 Line Summary
Address all CodeQL scan results.
Details
Address all issues detected by CodeQL in example project as well as change to the source.
Validation
Tests
Manually tested on macOS with Safari 17 to ensuring subscribing an unsubscribing works from the bell and custom link.
Info
Checklist
Programming Checklist
Interfaces:
Functions:
Typescript:
Other:
elem of arraysyntax. PreferforEachor usemapcontextif possible. Instead, we can pass it to function/constructor so that we don't callOneSignal.contextScreenshots
Info
Checklist
Related Tickets
This PR depends on PR #1121
This change is