[Fix] notification click event not firing if it opens a new tab #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue where
OneSignal.Notifications.addEventListener('click', function() {}) would
not fire when a notification was clicked that opens a new page.
Fixed by calling fireStoredNotificationClicks when a click listener is
added which checks the indexDb for any notification clicks that were
not processed for a specific URL.
emawby
approved these changes
Nov 14, 2023
rgomezp
approved these changes
Nov 14, 2023
| const stub = test.stub( | ||
| EventHelper, | ||
| 'fireStoredNotificationClicks', | ||
| null, |
There was a problem hiding this comment.
This is an optional argument. And I don't believe this function returns anything
There was a problem hiding this comment.
ah good catch, removed the null.
jkasten2
force-pushed
the
fix/notification_click_event_firing
branch
from
2a4587c to
901f308
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1 Line Summary
Fix notification click event not firing if it opens a new tab.
Details
The internal
fireStoredNotificationClicks()function was not called to fire any pending click events whenOneSignal.Notifications.addEventListener('click', function() {})is called.Validation
Tests
Tested on Chrome 119 on Window 11, testing both "focus" and "navigate" options for notification open behavior.
Info
Checklist
Programming Checklist
Interfaces:
Functions:
Typescript:
Other:
elem of arraysyntax. PreferforEachor usemapcontextif possible. Instead, we can pass it to function/constructor so that we don't callOneSignal.contextScreenshots
Tested click Behavior Exact:
Tested click behavior Focus:
Info
Checklist
Related Tickets
This change is