Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Replace deprecated CSS 'push-button'. Adds type='button' to Custom Link Prompt. #1170

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

marclucraft
Copy link
Contributor

@marclucraft marclucraft commented Apr 17, 2024

Description

  • Fixes warning in console: [Deprecation] The keyword 'push-button' specified to an 'appearance' property is not standardized. It will be removed in the future.
  • Adds type="button" to the Custom Link Button. This prevents this button submitting if included in a form.

Details

Both long standing bugs.

Systems Affected

  • WebSDK
  • Backend
  • Dashboard

Validation

Tests

Info

Checklist

  • All the automated tests pass or I explained why that is not possible
  • I have personally tested this on my machine or explained why that is not possible
  • I have included test coverage for these changes or explained why they are not needed

Programming Checklist
Interfaces:

  • Don't use default export
  • New interfaces are in model files

Functions:

  • Don't use default export
  • All function signatures have return types
  • Helpers should not access any data but rather be given the data to operate on.

Typescript:

  • No Typescript warnings
  • Avoid silencing null/undefined warnings with the exclamation point

Other:

  • Iteration: refrain from using elem of array syntax. Prefer forEach or use map
  • Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

image

image

Info

Checklist

  • I have included screenshots/recordings of the intended results or explained why they are not needed

Related Tickets



This change is Reviewable

- Warning in console: [Deprecation] The keyword 'push-button' specified to an 'appearance' property is not standardized. It will be removed in the future. */
- Adds type="button" to the Custom Link Button. This prevents this button submitting if included in a form.
Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Let's remove the comment about push-button since we are not using it anymore.
  • Change PR title to what is being addressed
    • Details in the PR can include that they are long standing bugs.

src/page/stylesheets/reset.scss Outdated Show resolved Hide resolved
@marclucraft marclucraft changed the title Fixes two long standing minor bugs [Fix] Replace deprecated CSS 'push-button'. Adds type='button' to Custom Link Prompt. Apr 17, 2024
@marclucraft marclucraft requested a review from jkasten2 April 17, 2024 16:04
@jkasten2 jkasten2 merged commit 5c4c81e into OneSignal:main Apr 17, 2024
4 checks passed
@jkasten2 jkasten2 mentioned this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants