Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Webhook dismissed not firing, and willDisplay when set from the dashboard #1174

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

jkasten2
Copy link
Member

@jkasten2 jkasten2 commented Apr 30, 2024

Description

One-Line Summary

Fixed issues with webhooks not reading parameters correctly, causing the dismissed and willDisplay to not fire.

Details

  • dismissed - this one was not firing at all due to the reading the wrong key from indexedDB
  • willDisplay - This one wasn't working if set from the dashboard, works fine with "custom code"

Validation

Tests

Tested all 3 notification events to ensure they fired on Chrome 123 on Windows 11 23H2; willDisplay, dismissed, and clicked.

Info

Checklist

  • All the automated tests pass or I explained why that is not possible
  • I have personally tested this on my machine or explained why that is not possible
  • I have included test coverage for these changes or explained why they are not needed

Programming Checklist
Interfaces:

  • Don't use default export
  • New interfaces are in model files

Functions:

  • Don't use default export
  • All function signatures have return types
  • Helpers should not access any data but rather be given the data to operate on.

Typescript:

  • No Typescript warnings
  • Avoid silencing null/undefined warnings with the exclamation point

Other:

  • Iteration: refrain from using elem of array syntax. Prefer forEach or use map
  • Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Info

Checklist

  • I have included screenshots/recordings of the intended results or explained why they are not needed

Related Tickets



This change is Reviewable

Since 160000 we have been using the wrong remote config key for the
webhook display event url. Reverted to the old name to correct the
issue.
This incorrect naming was causing the webhook not to fire, since it was
looking for the wrong key in IndexedDB
@jkasten2 jkasten2 merged commit 4472be3 into main Apr 30, 2024
4 checks passed
@jkasten2 jkasten2 deleted the fix/webhook-url-params branch April 30, 2024 22:39
@jkasten2 jkasten2 mentioned this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants