Fix SW scope handling of base html tag #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The results in the following warning after accepting notification
permissions
* [Service Worker Status] Error Checking service worker registration / DOMException: Failed to get a ServiceWorkerRegistration: The origin of the provided documentURL ('https://www.example.com') does not match the current origin ('https://localhost:4001').
* Followed by this error:
* [Worker Messenger] [Page -> SW] Could not get ServiceWorkerRegistration to postMessage!
* A relative path passed to the browser API navigator.serviceWorker.getRegistration respects the a base URL refined via a base html tag. * To combat we are making the add location.origin
* Updated getRegistration to support full URL like browsers do
* Added a rule that getRegistration should always start with location.origin due to the HTML base tag change relative urls. * Also updated all existing tests that did not follow this rule.
itrush
approved these changes
Feb 26, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 7 of 7 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @rgomezp)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1 Line Summary
Fixed regression introduced in #745 where we are no longer correctly handling relative URLs for the ServiceWorker scope when a
<base>HTML tag is added to the page.Details
Fixes issue where the page can't find the ServiceWorker if it is registered. Fixes the following warning + error printed to the console.
Only API affected by the base tag we were using was
navigator.serviceWorker.getRegistration.Systems Affected
Validation
Tests
Info
Checklist
Programming Checklist
Interfaces:
Functions:
Typescript:
Other:
elem of arraysyntax. PreferforEachor usemapcontextif possible. Instead, we can pass it to function/constructor so that we don't callOneSignal.contextScreenshots
Info
Checklist
Related Tickets
This change is