-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release workflow github action #1340
Conversation
This action is intended to build the binaries needed for an iOS release and open a PR with the changes. Developers will still need to 1. write release notes 2. Create the Github Release after merging the pr 3. Distribute the cocoapod
44e68ee
to
a993c0e
Compare
0b5e3e5
to
44268f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be worth refining this to disallow incorrect version numbers. For instance, releasing 4.0 when you meant 5. Even better would be automatically updating it by default based on the previous version.
Ya I avoided handling version numbers to keep complexity down, but this action also doesn't bump the version number in the SDK code or in the cocoa pod specs. Definitely would like to have this be as one button release as possible in the future and that is something we would need to add. I am not too worried about making mistakes with this action right now since it just makes a PR which can be fixed after the fact. |
This action basically does 2 build steps from the current release instructions and make a PR?
The hardest stuff to get right is still manual, but now we have to go dig for the generated XCFramework zips to attach to the GitHub release, and still need to validate we are attaching the right files, right? |
Yep this will help ensure that developers don't need to worry about which Xcode version they are compiling with and that the checksum in the Swift package is calculated using the correct zip. We will have a followup action that will create the Github release, push the pods, and attach the zips. |
Description
One Line Summary
Action for building the release binaries and updating the Package.swift for a release
Details
This action is intended to
It does NOT
How to use this action:
Motivation
Improve the release process
Manual testing
See the results of a test release here
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is