Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RYW retry-count first attempt sending 0 #1509

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

rgomezp
Copy link
Contributor

@rgomezp rgomezp commented Oct 31, 2024

Description

One Line Summary

Bugfix: should not be sending retry-count = 0 on first attempt / bring into parity with Android.

Details

Motivation

The retry count header for IAM fetch specifying retries should start at 1 to be in line with Android.

Testing

Manual testing

Ran the example app and inspected the first request to confirm the header is not being included for the first attempt.

1st:
Screenshot 2024-10-31 at 11 04 14 AM

2nd:
Screenshot 2024-10-31 at 11 04 30 AM

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable


Motivation: bring into parity with Android
@rgomezp rgomezp requested review from nan-li and Koji23 October 31, 2024 16:06
@rgomezp rgomezp merged commit 24cb7d2 into main Nov 1, 2024
3 of 4 checks passed
@rgomezp rgomezp deleted the fix/retry-count-0 branch November 1, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants