Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev app] replace app icon with new logo #1516

Merged
merged 2 commits into from
Nov 21, 2024
Merged

[dev app] replace app icon with new logo #1516

merged 2 commits into from
Nov 21, 2024

Conversation

nan-li
Copy link
Contributor

@nan-li nan-li commented Nov 14, 2024

Description

One Line Summary

Update example app icon to use new OneSignal logo and change an existing non-functional button to give some IDs for debugging (useful in built example apps).

Motivation

  • Logo update is requested by design, since we use the example app to build test apps, let's update the logo to the new OneSignal logo.
  • Non functional button is useful for giving some debugging IDs. The button is called Info

Scope

Example app only

Before and after:

Screenshot 2024-11-14 at 9 46 22 AM


This change is Reviewable

* There's a button that doesn't do anything, popup the OSID and push sub ID. This helps with users of the built example apps on TestFlight
@nan-li nan-li merged commit cb1502e into main Nov 21, 2024
4 checks passed
@nan-li nan-li deleted the update_app_icon branch November 21, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants