Fix requestPermission
to return false
when permission is denied
#1591
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Return the correct boolean for the
requestPermission
method when permission denied, and resolve correctly if permission is already granted.Details
Motivation
This was reported by a GitHub issue and I was able to reproduce. This method was always returning
true
previously on denial.In addition, we were not resolving if permission is already granted due to the Android implementation of suspend functions.
Scope
result.isSuccess()
which always returnstrue
because this is whether the coroutine call was successful.result.getData()
which holds the value returned by the coroutine.Testing
Unit testing
None
Manual testing
Android emulator API 33
true
andfalse
respectively.requestPermission
.Affected code checklist
Checklist
Overview
Testing
Final pass
This change is