Skip to content

Commit

Permalink
Fix Fanfares Killing Music Bug
Browse files Browse the repository at this point in the history
This fix comments out some useless code in Music.py that changes the cache load type to 2 for all sequences. There is no need to update this data as the cache load type is set correctly already.
  • Loading branch information
owlisnotacat1 committed Jul 2, 2023
1 parent e5de130 commit 3e0c419
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion Music.py
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,8 @@ def rebuild_sequences(rom: Rom, sequences: list[Sequence], log: CosmeticsLog, sy
rom.write_int32(0xB89AE0 + (i * 0x10), new_sequences[i].address)
rom.write_int32(0xB89AE0 + (i * 0x10) + 0x04, new_sequences[i].size)
seq = replacement_dict.get(i, None)
rom.write_int16(0xB89AE0 + (i * 0x10) + 0x08, seq.type)
#if seq:
# rom.write_int16(0xB89AE0 + (i * 0x10) + 0x08, seq.type) *This breaks fanfares and battle music as this sets the cache load type to 2 for every sequence. There is no need to update this data.

# Update instrument sets
for i in range(0x6E):
Expand Down

0 comments on commit 3e0c419

Please sign in to comment.