Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message for conflicting settings in plando #1862

Merged
merged 1 commit into from
Feb 4, 2023

Conversation

fenhl
Copy link
Collaborator

@fenhl fenhl commented Jan 29, 2023

Since #1562, this plando:

{
    "settings": {
        "bridge": "vanilla",
        "bridge_medallions": 6
    }
}

produces this error message:

ValueError: 'bridge_medallions' must be set to 0 since 'bridge' is set to 'vanilla'

This is misleading because 0 is not a valid option for bridge_medallions, and the actual fix is to remove bridge_medallions from the plando. This PR updates the error message accordingly:

ValueError: The 'bridge_medallions' setting cannot be used since 'bridge' is set to 'vanilla'

@cjohnson57 cjohnson57 added Type: Enhancement New feature or request Component: Plandomizer Plandomizer library and functionality labels Feb 4, 2023
@cjohnson57 cjohnson57 merged commit 35b0a09 into OoTRandomizer:Dev Feb 4, 2023
@fenhl fenhl deleted the settings-conflict-message branch February 4, 2023 22:34
@fenhl fenhl added this to the 8.0 milestone Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Plandomizer Plandomizer library and functionality Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants