-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom ice traps #1982
Custom ice traps #1982
Conversation
Requesting to resolve merge conflicts/update to the new typing reqs, this PR is fairly small so hopefully shouldn't be too bad |
73b42ca
to
a0a471e
Compare
Still need to make sure this actually works but I rebased it. |
It seems to be working now. Found a problem where it wasn't properly working because of pending junk but I think that's fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got some code style nits, this seems good other than that.
Co-authored-by: Fenhl <[email protected]>
Co-authored-by: Fenhl <[email protected]>
Co-authored-by: Fenhl <[email protected]>
Co-authored-by: Fenhl <[email protected]>
Co-authored-by: Fenhl <[email protected]>
Co-authored-by: Fenhl <[email protected]>
Co-authored-by: Fenhl <[email protected]>
I must have done something wrong so GitHub didn't auto-close this PR, but this was merged in a75ab38. |
Adds setting to select a custom amount of ice traps. When pots/crates/etc. are enabled, there is a pretty big jump between Ice Trap "Mayhem" and "Onslaught" because all of the junk items from pots don't get included under Mayhem. This setting allows more fine-grained control over how many ice traps are in the seed.
Two additional items are available under the "Ice Traps" drop down:
In both of these cases, "Junk" items includes base pool junk.