Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial PoC for non-recursive copy. #2068

Merged
merged 1 commit into from
Aug 13, 2023

Conversation

Cuphat
Copy link
Collaborator

@Cuphat Cuphat commented Aug 11, 2023

Fix for #2032.

Not my finest looking code and needs polishing, but it removes the recursion from copying while maintaining copy quality.

@Cuphat Cuphat added the Type: Bug Something isn't working label Aug 11, 2023
@fenhl fenhl added the Component: Randomizer Core Generally the core functions of the python label Aug 11, 2023
@fenhl
Copy link
Collaborator

fenhl commented Aug 11, 2023

If you edit the PR description to say “Fixes” instead of “Fix for”, the issue will be automatically closed when this PR is merged.

@cjohnson57
Copy link
Collaborator

So you removed the copy_dict and added a Copier class, that's only used when creating the spoiler. I guess the copy_dict was only really used for the spoiler? Which makes sense, considering that's where the issue came from

Spoiler.py Show resolved Hide resolved
@cjohnson57 cjohnson57 merged commit 3c24413 into OoTRandomizer:Dev Aug 13, 2023
3 checks passed
@Cuphat Cuphat deleted the remove_copy_recursion branch August 13, 2023 07:37
@fenhl fenhl added this to the 8.0 milestone Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Randomizer Core Generally the core functions of the python Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants