Fix boss keys being shuffled when they shouldn't be #2071
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the following conditions were true:
Then the boss keys would still be shuffled into the item pool, even though they shouldn't be.
As
vanilla
overrides the key ring setting, it's correct to still shuffle the BK in this case. However,dungeon
andremove
were excluded from this as well. You could argue that it makes sense to still shuffle the BKs underremove
since BKs have their own keysy setting, but under current behavior you'll still start with the BK in this situation, so it doesn't make sense to also shuffle it. I changed both times this is checked for (for the base and plentiful item pool) to specifically check forvanilla
.