Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix boss keys being shuffled when they shouldn't be #2071

Merged
merged 2 commits into from
Aug 26, 2023

Conversation

cjohnson57
Copy link
Collaborator

@cjohnson57 cjohnson57 commented Aug 13, 2023

If the following conditions were true:

  • Key rings were on for a dungeon
  • Key rings were set to give boss keys
  • Small keys were set to own dungeon or keysy

Then the boss keys would still be shuffled into the item pool, even though they shouldn't be.

As vanilla overrides the key ring setting, it's correct to still shuffle the BK in this case. However, dungeon and remove were excluded from this as well. You could argue that it makes sense to still shuffle the BKs under remove since BKs have their own keysy setting, but under current behavior you'll still start with the BK in this situation, so it doesn't make sense to also shuffle it. I changed both times this is checked for (for the base and plentiful item pool) to specifically check for vanilla.

@fenhl fenhl added Type: Bug Something isn't working Component: Randomizer Core Generally the core functions of the python labels Aug 13, 2023
@cjohnson57 cjohnson57 merged commit c2c66c5 into OoTRandomizer:Dev Aug 26, 2023
3 checks passed
@fenhl fenhl added this to the 8.0 milestone Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Randomizer Core Generally the core functions of the python Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants