Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve music sequence identification for the two relevant SFX settings #2075

Merged
merged 1 commit into from
Aug 26, 2023

Conversation

GSKirox
Copy link
Collaborator

@GSKirox GSKirox commented Aug 22, 2023

The cosmetics settings 'Speed Up Music For Last Triforce Piece' and 'Slow Down Music When Low HP' relied on looking at the seq_index value of the structure z64_file to identify when to apply the change.
This had the drawback of not noticing some specific cases where another music sequence play on top of the current one played in the area, such as the miniboss music in dungeons, the windmill track, or the "Master Sword" track when you switch age in Temple of Time.
Instead, we now use this function : https://github.com/zeldaret/oot/blob/master/src/audio/sequence.c#L410
Which gives the accurate sequence index in every situation, and will correctly apply the music change on all specific cases stated above.

@fenhl fenhl added Type: Bug Something isn't working Component: Cosmetics Affects the patching of cosmetics labels Aug 22, 2023
@cjohnson57 cjohnson57 merged commit 1f06fa4 into OoTRandomizer:Dev Aug 26, 2023
3 checks passed
@GSKirox GSKirox deleted the improve_music_seq_search branch August 31, 2023 09:41
@fenhl fenhl added this to the 8.0 milestone Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Cosmetics Affects the patching of cosmetics Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants